From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Kishon <kishon@ti.com>, linux-omap <linux-omap@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mmc: core: Lower max_seg_size if too high for DMA
Date: Tue, 11 Dec 2018 06:23:43 -0800 [thread overview]
Message-ID: <20181211142343.GO6707@atomide.com> (raw)
In-Reply-To: <b88f7a3f-ed0e-c6d7-6e18-afc2378524bf@ti.com>
* Peter Ujfalusi <peter.ujfalusi@ti.com> [181211 13:47]:
> On 11/12/2018 15.13, Russell King - ARM Linux wrote:
> > The only thing I can think of doing is adding into omap_hsmmc:
> >
> > mmc->max_seg_size = min(mmc->max_req_size,
> > min(dma_get_max_seg_size(host->rx_chan->device->dev),
> > dma_get_max_seg_size(host->tx_chan->device->dev)));
> >
> > to limit the maximum segment size to that of the device _and_ dma
> > engine's capabilities.
>
> Make sense.
>
> > Doing this solves the problem for me.
OK sounds good to me too.
Thanks,
Tony
prev parent reply other threads:[~2018-12-11 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 15:57 [PATCH] mmc: core: Lower max_seg_size if too high for DMA Tony Lindgren
2018-11-12 16:48 ` Peter Ujfalusi
2018-11-19 12:08 ` Ulf Hansson
2018-11-29 19:13 ` Tony Lindgren
2018-11-29 20:11 ` Ulf Hansson
2018-12-11 13:13 ` Russell King - ARM Linux
2018-12-11 13:39 ` Ulf Hansson
2018-12-11 13:49 ` Russell King - ARM Linux
2018-12-11 14:33 ` Peter Ujfalusi
2018-12-11 14:42 ` Russell King - ARM Linux
2018-12-11 13:49 ` Peter Ujfalusi
2018-12-11 14:23 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211142343.GO6707@atomide.com \
--to=tony@atomide.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peter.ujfalusi@ti.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).