Re: [PATCH V7 2/2] mmc: tegra: HW Command Queue Support for Tegra SDMMC

Chunyan Zhang
2019-01-15T03:10:46Z

On Fri, Jan 11, 2019 at 8:58 AM Sowjanya Komatineni
<skomatineni@nvidia.com> wrote:
>
> >> +static int sdhci_tegra_add_host(struct sdhci_host *host) {
> >> + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> >> + struct sdhci_tegra *tegra_host = sdhci_pltfm_priv(pltfm_host);
> >> + struct cqhci_host *cq_host;
> >> + bool dma64;
> >> + int ret;
> >> +
> >> + if (!tegra_host->enable_hwcq)
> >> + return sdhci_add_host(host);
> >> +
> >> + host->v4_mode = true;
> >
> >Can you use sdhci_enable_v4_mode() here?
>
> Hi Adrian,
> sdhci_read_caps sets v4 mode thru sdhci_do_enable_v4_mode if v4_mode is true
> sdhci_setup_host calls sdhci_read_caps so I was setting v4_mode to true so v4 mode gets enabled during read caps.
>

Hi sowjanya,

I also would suggest to use sdhci_enable_v4_mode() instead of setting
host->v4_mode directly.
Enabling v4_mode in read caps was just because that I was worried
about v4 mode would be cleared after reset all on some controllers. If
that's not the case for all sd host controllers, I guess it can be
removed.

Thanks,
Chunyan