Re: [PATCH v2 0/8] Port am335 and am437 devices to sdhci-omap

Tony Lindgren
2019-02-18T16:25:17Z

* Faiz Abbas <faiz_abbas@ti.com> [190218 13:46]:
> Hi Tony,
>
> On 16/02/19 1:32 AM, Tony Lindgren wrote:
> > * Faiz Abbas <faiz_abbas@ti.com> [190215 19:17]:
> >> The following add driver patches for porting TI's am335x and am437x
> >> devices to the sdhci-omap driver.
> >>
> >> This involves adding external DMA support to sdhci (first 3 patches from
> >> Chunyan) plus some miscellaneous patches to take care of deviations of
> >> the controllers from the sdhci model.
> >
> > Good to see this happening :)
> >
> > I think am437x should have also the ADMA as it's mostly
> > omap4 based? See the old omap4 ADMA series at [0] below.
> >
> > Are you seeing any improvment in SDIO card read/write speeds
> > between external DMA and ADM BTW
>
> am437 is using dmaengine even in the old omap_hsmmc driver. I haven't
> tried to enable ADMA in am437x.

Right, it's probably safest to keep it that way at least initially
to avoid changing multiple things at once. Then ADMA can be
configured later on if needed.

Regards,

Tony