* [PATCH] mmc: core: Fix warning and undefined behavior in mmc voltage handling
@ 2019-04-16 7:58 Pavel Machek
2019-04-29 10:44 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Machek @ 2019-04-16 7:58 UTC (permalink / raw)
To: ulf.hansson, linux-kernel, linux-mmc
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
!voltage_ranges is tested for too late, allowing warning and undefined
behavior. Fix that.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 3a4402a..b3fa9c9 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -363,11 +363,11 @@ int mmc_of_parse_voltage(struct device_node *np, u32 *mask)
int num_ranges, i;
voltage_ranges = of_get_property(np, "voltage-ranges", &num_ranges);
- num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
if (!voltage_ranges) {
pr_debug("%pOF: voltage-ranges unspecified\n", np);
return 0;
}
+ num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
if (!num_ranges) {
pr_err("%pOF: voltage-ranges empty\n", np);
return -EINVAL;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mmc: core: Fix warning and undefined behavior in mmc voltage handling
2019-04-16 7:58 [PATCH] mmc: core: Fix warning and undefined behavior in mmc voltage handling Pavel Machek
@ 2019-04-29 10:44 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2019-04-29 10:44 UTC (permalink / raw)
To: Pavel Machek; +Cc: Linux Kernel Mailing List, linux-mmc@vger.kernel.org
On Tue, 16 Apr 2019 at 09:58, Pavel Machek <pavel@ucw.cz> wrote:
>
>
> !voltage_ranges is tested for too late, allowing warning and undefined
> behavior. Fix that.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
Applied for next, thanks!
Kind regards
Uffe
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 3a4402a..b3fa9c9 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -363,11 +363,11 @@ int mmc_of_parse_voltage(struct device_node *np, u32 *mask)
> int num_ranges, i;
>
> voltage_ranges = of_get_property(np, "voltage-ranges", &num_ranges);
> - num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
> if (!voltage_ranges) {
> pr_debug("%pOF: voltage-ranges unspecified\n", np);
> return 0;
> }
> + num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
> if (!num_ranges) {
> pr_err("%pOF: voltage-ranges empty\n", np);
> return -EINVAL;
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-29 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-16 7:58 [PATCH] mmc: core: Fix warning and undefined behavior in mmc voltage handling Pavel Machek
2019-04-29 10:44 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).