From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep Date: Mon, 20 May 2019 17:23:14 -0700 Message-ID: <20190521002312.GA89786@google.com> References: <20190517225420.176893-1-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Avri Altman Cc: Douglas Anderson , Ulf Hansson , Kalle Valo , Adrian Hunter , Arend van Spriel , "linux-rockchip@lists.infradead.org" , Double Lo , Madhan Mohan R , "mka@chromium.org" , Wright Feng , Chi-Hsien Lin , "linux-mmc@vger.kernel.org" , Shawn Lin , "brcm80211-dev-list@cypress.com" , YueHaibing , Hante Meuleman , Martin Hicks List-Id: linux-mmc@vger.kernel.org On Sat, May 18, 2019 at 03:09:44PM +0000, Avri Altman wrote: > > > > This series attempts to deal better with the expected transmission > > errors that we get when waking up the SDIO-based WiFi on > > rk3288-veyron-minnie, rk3288-veyron-speedy, and rk3288-veyron-mickey. > > > > Some details about those errors can be found in > > , but to summarize it here: if we try to > > send the wakeup command to the WiFi card at the same time it has > > decided to wake up itself then it will behave badly on the SDIO bus. > > This can cause timeouts or CRC errors. > Wake-up itself: as part of a WoWlan, or d0i3? Neither, IIUC. (It's definitely not WoWLAN, and D0i3 sounds like an Intel thing.) I believe it's a Broadcom-specific mode. See also Arend's response to this thread: http://lkml.kernel.org/linux-wireless/8c3fa57a-3843-947c-ec6b-a6144ccde1e9@broadcom.com > Looks like this calls for a wifi driver fix, and not WA in the mmc driver. Basically asked and answered in patch 2's thread: https://lkml.kernel.org/lkml/20190520085201.GA1021@kunai/