From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux admin Subject: Re: [REGRESSION] sdhci no longer detects SD cards on LX2160A Date: Tue, 17 Sep 2019 14:33:17 +0100 Message-ID: <20190917133317.GQ25745@shell.armlinux.org.uk> References: <20190916171509.GG25745@shell.armlinux.org.uk> <20190917081931.GI25745@shell.armlinux.org.uk> <20190917104200.GJ25745@shell.armlinux.org.uk> <20190917111631.GL25745@shell.armlinux.org.uk> <20190917114210.GM25745@shell.armlinux.org.uk> <20190917123326.GN25745@shell.armlinux.org.uk> <20190917130759.GO25745@shell.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Fabio Estevam Cc: dann frazier , linux-mmc , Adrian Hunter , Will Deacon , Nicolin Chen , Christoph Hellwig , Linux ARM List-Id: linux-mmc@vger.kernel.org On Tue, Sep 17, 2019 at 10:24:57AM -0300, Fabio Estevam wrote: > Hi Russell, > > On Tue, Sep 17, 2019 at 10:10 AM Russell King - ARM Linux admin > wrote: > > > Will suggested reverting bd2e75633c80 ("dma-contiguous: use fallback > > alloc_pages for single pages") which has been implicated in the same > > problem here: > > > > https://www.spinics.net/lists/arm-kernel/msg750623.html > > It seems that the final fix was: > https://lore.kernel.org/patchwork/patch/1121600/ > > Does it work for you if we follow the same idea? > > --- a/drivers/mmc/host/sdhci-of-esdhc.c > +++ b/drivers/mmc/host/sdhci-of-esdhc.c > @@ -1105,6 +1105,7 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) > > esdhc_init(pdev, host); > > + sdhci_enable_v4_mode(host); > sdhci_get_of_property(pdev); > > pltfm_host = sdhci_priv(host); That attempts to set bit 12 of the host control register 2 (0x3e). The LX2160A documentation states that bit 28 of 0x3c (they're 32-bit wide registers there) is "reserved". So, you're asking for a documented reserved bit to be set... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up