From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 5/6] mmc: sdhci-acpi: Switch to use acpi_dev_hid_uid_match() Date: Tue, 1 Oct 2019 16:04:43 +0300 Message-ID: <20191001130443.GN32742@smile.fi.intel.com> References: <20190924193739.86133-1-andriy.shevchenko@linux.intel.com> <20190924193739.86133-6-andriy.shevchenko@linux.intel.com> <77ce4e34-6692-e54e-0f2f-6b8829d1e9f5@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <77ce4e34-6692-e54e-0f2f-6b8829d1e9f5-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Adrian Hunter Cc: Ulf Hansson , linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-mmc@vger.kernel.org On Tue, Oct 01, 2019 at 03:37:08PM +0300, Adrian Hunter wrote: > On 24/09/19 10:37 PM, Andy Shevchenko wrote: > > Since we have a generic helper, drop custom implementation in the driver. > > - if (strcmp(hid, "QCOM8051")) > > + if (acpi_dev_hid_uid_match(adev, "QCOM8051", NULL)) > > Logic is inverted Good catch! I forgot to double check it here while below it's okay... > > - if (strcmp(hid, "QCOM8051")) > > + if (!acpi_dev_hid_uid_match(adev, "QCOM8051", NULL)) -- With Best Regards, Andy Shevchenko