From: patrick.oppenlander@gmail.com
To: linux-mmc@vger.kernel.org
Cc: Patrick Oppenlander <patrick.oppenlander@gmail.com>
Subject: [PATCH] mmc-utils: Fix scaling of cache size
Date: Fri, 14 Feb 2020 09:13:32 +1100 [thread overview]
Message-ID: <20200213221332.2228810-1-patrick.oppenlander@gmail.com> (raw)
From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
JESD84-B51 7.4.30 CACHE_SIZE [252:249] states that "the size is
indicated as multiple of kilobits". This is also supported by Table 39,
"e.MMC internal sizes and related Units / Granularities" which lists
"32Kb (=4KB)" as the cache size granularity for 4KiB native devices.
Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
---
mmc_cmds.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mmc_cmds.c b/mmc_cmds.c
index fb37189..a1b1d75 100644
--- a/mmc_cmds.c
+++ b/mmc_cmds.c
@@ -1419,8 +1419,8 @@ int do_read_extcsd(int nargs, char **argv)
printf("Power off notification [POWER_OFF_LONG_TIME: 0x%02x]\n",
ext_csd[247]);
printf("Cache Size [CACHE_SIZE] is %d KiB\n",
- ext_csd[249] << 0 | (ext_csd[250] << 8) |
- (ext_csd[251] << 16) | (ext_csd[252] << 24));
+ (ext_csd[249] << 0 | (ext_csd[250] << 8) |
+ (ext_csd[251] << 16) | (ext_csd[252] << 24)) / 8);
}
/* A441: Reserved [501:247]
--
2.25.0
next reply other threads:[~2020-02-13 22:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 22:13 patrick.oppenlander [this message]
2020-02-16 7:18 ` [PATCH] mmc-utils: Fix scaling of cache size Avri Altman
2020-03-31 21:11 ` Patrick Oppenlander
2020-04-01 8:20 ` Ulf Hansson
2020-04-01 22:14 ` patrick.oppenlander
2020-07-23 7:17 ` Patrick Oppenlander
2021-03-31 9:40 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213221332.2228810-1-patrick.oppenlander@gmail.com \
--to=patrick.oppenlander@gmail.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).