From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43ACCC10DCE for ; Fri, 6 Mar 2020 14:19:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22664206CC for ; Fri, 6 Mar 2020 14:19:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726171AbgCFOTx (ORCPT ); Fri, 6 Mar 2020 09:19:53 -0500 Received: from verein.lst.de ([213.95.11.211]:36853 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbgCFOTx (ORCPT ); Fri, 6 Mar 2020 09:19:53 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id DB97468AFE; Fri, 6 Mar 2020 15:19:50 +0100 (CET) Date: Fri, 6 Mar 2020 15:19:50 +0100 From: Christoph Hellwig To: Ulf Hansson Cc: Christoph Hellwig , Linus Walleij , Greg KH , Arnd Bergmann , Haibo Chen , Adrian Hunter , "linux-mmc@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH v4 14/14] mmc: queue: create dev->dma_parms before call dma_set_max_seg_size() Message-ID: <20200306141950.GA1017@lst.de> References: <1582100757-20683-1-git-send-email-haibo.chen@nxp.com> <1582100757-20683-9-git-send-email-haibo.chen@nxp.com> <20200304162844.GA11727@lst.de> <20200305152337.GC4870@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Fri, Mar 06, 2020 at 03:02:09PM +0100, Ulf Hansson wrote: > That makes sense to me, but we also have other bus types to consider, > like the amba bus for example. > > So, in principle, those buses that may get DMA capable devices > attached, needs to do the allocation, that's what you are proposing? Having a dma_params allocated doesn't mean all devices are dma capable, for example there are PCI devices that aren't as well.