From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH v2 1/2] mmc: renesas_sdhi: handle M3-N ES1.2 and 1.3 revisions
Date: Thu, 23 Apr 2020 14:39:56 +0200 [thread overview]
Message-ID: <20200423123955.GB1130@ninjato> (raw)
In-Reply-To: <CAMuHMdW0OuHy4ikQz3oY+koqLskXtcXJkUVLZYqsW+niT1pLDQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]
> Usually we don't add soc_device_match quirks for unknown future revisions.
I was just following...
>
> > --- a/drivers/mmc/host/renesas_sdhi_core.c
> > +++ b/drivers/mmc/host/renesas_sdhi_core.c
> > @@ -711,11 +711,17 @@ static const struct renesas_sdhi_quirks sdhi_quirks_nohs400 = {
> > .hs400_disabled = true,
> > };
> >
> > +/*
> > + * Note for r8a7796 / r8a774a1: we can't distinguish ES1.1 and 1.2 as of now.
> > + * So, we want to treat them equally and only have a match for ES1.2 to enforce
> > + * this if there ever will be a way to distinguish ES1.2.
> > + */
> > static const struct soc_device_attribute sdhi_quirks_match[] = {
> > { .soc_id = "r8a774a1", .revision = "ES1.[012]", .data = &sdhi_quirks_4tap_nohs400 },
> > { .soc_id = "r8a7795", .revision = "ES1.*", .data = &sdhi_quirks_4tap_nohs400 },
... this example here. This also applies to all future versions (not
that there will be any), no?
> > { .soc_id = "r8a7795", .revision = "ES2.0", .data = &sdhi_quirks_4tap },
> > { .soc_id = "r8a7796", .revision = "ES1.[012]", .data = &sdhi_quirks_4tap_nohs400 },
> > + { .soc_id = "r8a7796", .revision = "ES1.*", .data = &sdhi_quirks_4tap },
>
> R-Car M3-N is r8a77965, not r8a7796?
Right. $subject should be M3-W :(
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-23 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 12:24 [PATCH v2 0/2] mmc: renesas_sdhi: avoid bad TAPs for Gen3 Wolfram Sang
2020-04-23 12:24 ` [PATCH v2 1/2] mmc: renesas_sdhi: handle M3-N ES1.2 and 1.3 revisions Wolfram Sang
2020-04-23 12:35 ` Geert Uytterhoeven
2020-04-23 12:39 ` Wolfram Sang [this message]
2020-04-23 12:44 ` Geert Uytterhoeven
2020-04-23 12:48 ` Wolfram Sang
2020-04-23 12:24 ` [PATCH v2 2/2] mmc: renesas_sdhi: Avoid bad TAP in HS400 Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423123955.GB1130@ninjato \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox