From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Ulrich Hecht <uli+renesas@fpond.eu>,
Simon Horman <horms+renesas@verge.net.au>,
Niklas Soderlund <niklas.soderlund@ragnatech.se>
Subject: Re: [PATCH 2/2] mmc: tmio: Make sure the PM domain is 'started' while probing
Date: Tue, 19 May 2020 13:35:45 +0200 [thread overview]
Message-ID: <20200519113545.GK1094@ninjato> (raw)
In-Reply-To: <CAPDyKFr0Pfge4tm5MQmnmjx7Pvjjf16tLr47wYiR-2ys69Ux2A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
> This means dev_pm_domain_start() is needed only for the SDHI renesas
> variants. But on the other hand, it doesn't hurt for the others (the
> uniphier-sd variant doesn't even use runtime PM as confirmed by
> Yamada-san).
>
> I don't have a strong opinion, but it looks like we can either apply
> $subject patch as is, or modify it to make dev_pm_domain_start() be
> called only for the SDHI renesas variants.
>
> What do you prefer?
Dealing with PM is confusing often enough. To keep it simple, I'd
suggest to avoid unneeded calls. It may take a while later to rediscover
if this call is essential or not. So, for the uniphier case, we know it
is not needed. If we agree on a best effort basis that it is also not
needed for tmio_mmc, then I think we should keep it only for Renesas
SDHI.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-19 11:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 14:04 [PATCH 2/2] mmc: tmio: Make sure the PM domain is 'started' while probing Ulf Hansson
2020-05-18 20:22 ` Wolfram Sang
2020-05-19 7:50 ` Ulf Hansson
2020-05-19 8:46 ` Wolfram Sang
2020-05-19 8:53 ` Geert Uytterhoeven
2020-05-19 9:09 ` Wolfram Sang
2020-05-19 9:15 ` Ulf Hansson
2020-05-19 9:21 ` Ulf Hansson
2020-05-19 11:32 ` Wolfram Sang
2020-05-19 11:35 ` Wolfram Sang [this message]
2020-05-19 13:54 ` Ulf Hansson
2020-05-18 21:07 ` Geert Uytterhoeven
2020-05-19 8:18 ` Ulf Hansson
2020-05-19 8:29 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2020-05-19 15:24 Ulf Hansson
2020-05-19 16:38 ` Wolfram Sang
2020-05-20 11:35 ` Ulf Hansson
2020-05-20 15:57 ` Geert Uytterhoeven
2020-05-20 16:11 ` Ulf Hansson
2020-05-20 17:42 ` Geert Uytterhoeven
2020-05-25 8:47 ` Ulf Hansson
2020-05-25 10:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519113545.GK1094@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=ulf.hansson@linaro.org \
--cc=uli+renesas@fpond.eu \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox