From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-mmc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Takeshi Saito <takeshi.saito.xv@renesas.com>
Subject: Re: [RFC PATCH v3 2/2] mmc: renesas_sdhi: support manual calibration
Date: Thu, 4 Jun 2020 21:21:04 +0200 [thread overview]
Message-ID: <20200604192104.GA26501@ninjato> (raw)
In-Reply-To: <20200604120633.22795-3-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
> + if (ver == SDHI_VER_GEN3_SDMMC && quirks && quirks->hs400_calib_table) {
> + host->fixup_request = renesas_sdhi_fixup_request;
> + priv->adjust_hs400_calib_table = *(
> + res->start == SDHI_GEN3_MMC0_ADDR ?
> + quirks->hs400_calib_table :
> + quirks->hs400_calib_table + 1);
> + }
> +
Testing revealed that this chunk should be moved up before calling
tmio_mmc_host_probe(). After that, output from R-Car M3-N and H3 ES2.0
were as expected. Updated debug test patch was pushed out to the branch
as well. Tomorrow, I will test R-Car H2 and if all goes well, I will
send out the fixed and non-RFC version of this series.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-06-04 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 12:06 [RFC PATCH v3 0/2] mmc: renesas_sdhi: support manual calibration Wolfram Sang
2020-06-04 12:06 ` [RFC PATCH v3 1/2] mmc: tmio: add generic hook to fixup after a completed request Wolfram Sang
2020-06-04 12:06 ` [RFC PATCH v3 2/2] mmc: renesas_sdhi: support manual calibration Wolfram Sang
2020-06-04 19:21 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604192104.GA26501@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=takeshi.saito.xv@renesas.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox