Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

Geert Uytterhoeven
2020-08-13T07:51:11Z

Hi Rob,

On Wed, Aug 12, 2020 at 10:36 PM Rob Herring <robh@kernel.org> wrote:
> Clean-up incorrect indentation, extra spaces, long lines, and missing
> EOF newline in schema files. Most of the clean-ups are for list
> indentation which should always be 2 spaces more than the preceding
> keyword.
>
> Found with yamllint (which I plan to integrate into the checks).

> Signed-off-by: Rob Herring <robh@kernel.org>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-clocks.yaml
> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-clocks.yaml
> @@ -24,9 +24,9 @@ properties:
> - const: renesas,r8a7778-cpg-clocks # R-Car M1
> - const: renesas,r8a7779-cpg-clocks # R-Car H1
> - items:
> - - enum:
> - - renesas,r7s72100-cpg-clocks # RZ/A1H
> - - const: renesas,rz-cpg-clocks # RZ/A1
> + - enum:
> + - renesas,r7s72100-cpg-clocks # RZ/A1H
> + - const: renesas,rz-cpg-clocks # RZ/A1

This change breaks alignment of the comments at the end of each line.

> - const: renesas,sh73a0-cpg-clocks # SH-Mobile AG5

(I only checked the files I care about)

If you don't update commit e0fe7fc6f2ca0781 ("dt-bindings: Whitespace
clean-ups in schema files"), I can send a patch after v5.9-rc1.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds