* [PATCH] mmc: test: remove ambiguity in test description
@ 2020-08-17 11:58 Wolfram Sang
2020-08-20 6:56 ` Niklas Söderlund
2020-08-24 9:50 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2020-08-17 11:58 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-renesas-soc, Wolfram Sang
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
When reading the test description, I thought a correction of the
xfer_size was tested, which is not the case. It is tested that the
xfer_size is correct. Use 'proper xfer_size' to remove this ambiguity.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
This may be bike-shedding and I am not offended if you think it is
minor. However, I ended up looking at the source wondering where is what
automatically corrected.
drivers/mmc/core/mmc_test.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
index c21b3cb71775..152e7525ed33 100644
--- a/drivers/mmc/core/mmc_test.c
+++ b/drivers/mmc/core/mmc_test.c
@@ -2669,22 +2669,22 @@ static const struct mmc_test_case mmc_test_cases[] = {
},
{
- .name = "Correct xfer_size at write (start failure)",
+ .name = "Proper xfer_size at write (start failure)",
.run = mmc_test_xfersize_write,
},
{
- .name = "Correct xfer_size at read (start failure)",
+ .name = "Proper xfer_size at read (start failure)",
.run = mmc_test_xfersize_read,
},
{
- .name = "Correct xfer_size at write (midway failure)",
+ .name = "Proper xfer_size at write (midway failure)",
.run = mmc_test_multi_xfersize_write,
},
{
- .name = "Correct xfer_size at read (midway failure)",
+ .name = "Proper xfer_size at read (midway failure)",
.run = mmc_test_multi_xfersize_read,
},
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: test: remove ambiguity in test description
2020-08-17 11:58 [PATCH] mmc: test: remove ambiguity in test description Wolfram Sang
@ 2020-08-20 6:56 ` Niklas Söderlund
2020-08-24 9:50 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2020-08-20 6:56 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, linux-renesas-soc, Wolfram Sang
Hi Wolfram,
Thanks for your work.
On 2020-08-17 13:58:38 +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> When reading the test description, I thought a correction of the
> xfer_size was tested, which is not the case. It is tested that the
> xfer_size is correct. Use 'proper xfer_size' to remove this ambiguity.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
For what it's worth,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>
> This may be bike-shedding and I am not offended if you think it is
> minor. However, I ended up looking at the source wondering where is what
> automatically corrected.
>
> drivers/mmc/core/mmc_test.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index c21b3cb71775..152e7525ed33 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -2669,22 +2669,22 @@ static const struct mmc_test_case mmc_test_cases[] = {
> },
>
> {
> - .name = "Correct xfer_size at write (start failure)",
> + .name = "Proper xfer_size at write (start failure)",
> .run = mmc_test_xfersize_write,
> },
>
> {
> - .name = "Correct xfer_size at read (start failure)",
> + .name = "Proper xfer_size at read (start failure)",
> .run = mmc_test_xfersize_read,
> },
>
> {
> - .name = "Correct xfer_size at write (midway failure)",
> + .name = "Proper xfer_size at write (midway failure)",
> .run = mmc_test_multi_xfersize_write,
> },
>
> {
> - .name = "Correct xfer_size at read (midway failure)",
> + .name = "Proper xfer_size at read (midway failure)",
> .run = mmc_test_multi_xfersize_read,
> },
>
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: test: remove ambiguity in test description
2020-08-17 11:58 [PATCH] mmc: test: remove ambiguity in test description Wolfram Sang
2020-08-20 6:56 ` Niklas Söderlund
@ 2020-08-24 9:50 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-08-24 9:50 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc@vger.kernel.org, Linux-Renesas, Wolfram Sang
On Mon, 17 Aug 2020 at 13:58, Wolfram Sang <wsa@kernel.org> wrote:
>
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> When reading the test description, I thought a correction of the
> xfer_size was tested, which is not the case. It is tested that the
> xfer_size is correct. Use 'proper xfer_size' to remove this ambiguity.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
>
> This may be bike-shedding and I am not offended if you think it is
> minor. However, I ended up looking at the source wondering where is what
> automatically corrected.
>
> drivers/mmc/core/mmc_test.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index c21b3cb71775..152e7525ed33 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -2669,22 +2669,22 @@ static const struct mmc_test_case mmc_test_cases[] = {
> },
>
> {
> - .name = "Correct xfer_size at write (start failure)",
> + .name = "Proper xfer_size at write (start failure)",
> .run = mmc_test_xfersize_write,
> },
>
> {
> - .name = "Correct xfer_size at read (start failure)",
> + .name = "Proper xfer_size at read (start failure)",
> .run = mmc_test_xfersize_read,
> },
>
> {
> - .name = "Correct xfer_size at write (midway failure)",
> + .name = "Proper xfer_size at write (midway failure)",
> .run = mmc_test_multi_xfersize_write,
> },
>
> {
> - .name = "Correct xfer_size at read (midway failure)",
> + .name = "Proper xfer_size at read (midway failure)",
> .run = mmc_test_multi_xfersize_read,
> },
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-24 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-17 11:58 [PATCH] mmc: test: remove ambiguity in test description Wolfram Sang
2020-08-20 6:56 ` Niklas Söderlund
2020-08-24 9:50 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).