Re: [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property

Krzysztof Kozlowski
2020-08-24T06:38:17Z

On Mon, Aug 24, 2020 at 07:24:46AM +0200, Sascha Hauer wrote:
> On Sun, Aug 23, 2020 at 06:15:30PM +0200, Krzysztof Kozlowski wrote:
> > The GPIO controller node can have gpio-ranges property. This fixes
> > dtbs_check warnings like:
> >
> > arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000: 'gpio-ranges' does not match any of the regexes: 'pinctrl-[0-9]+'
> > From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > .../devicetree/bindings/gpio/fsl-imx-gpio.yaml | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > index 454db20c2d1a..1fac69573bb9 100644
> > --- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > @@ -51,6 +51,9 @@ properties:
> >
> > gpio-controller: true
> >
> > + gpio-ranges:
> > + maxItems: 1
> > +
> > required:
> > - compatible
> > - reg
> > @@ -62,6 +65,18 @@ required:
> >
> > additionalProperties: false
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: fsl,imx8mp-gpio
> > + then:
> > + properties:
> > + gpio-ranges:
> > + minItems: 1
> > + maxItems: 2
>
> Why do you limit this to fsl,imx8mp-gpio? The i.MX5,6,7 dtsi files use
> gpio-ranges as well and other i.MX dtsi files could also use it.

All other cases use maximum one element in gpio-ranges, so they are
covered so I assumed they are continuous. But if it not the case, I can
make all them maximum 2.

Best regards,
Krzysztof