Re: [PATCH v2 13/19] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles

Sascha Hauer
2020-08-25T04:47:41Z

On Mon, Aug 24, 2020 at 06:26:46PM +0200, Krzysztof Kozlowski wrote:
> + oneOf:
> + - items:
> + - enum:
> + - fsl,imx6q-ocotp
> + - fsl,imx6sl-ocotp
> + - fsl,imx6sx-ocotp
> + - fsl,imx6ul-ocotp
> + - fsl,imx6ull-ocotp
> + - fsl,imx7d-ocotp
> + - fsl,imx6sll-ocotp
> + - fsl,imx7ulp-ocotp
> + - fsl,imx8mq-ocotp
> + - fsl,imx8mm-ocotp
> + - fsl,imx8mn-ocotp
> + - fsl,imx8mp-ocotp
> + - const: syscon
> + - items:
> + # The devices are not really compatible with fsl,imx8mm-ocotp, however
> + # the code for getting SoC revision depends on fsl,imx8mm-ocotp compatible.

Shouldn't this be fixed? It seems strange to justify a binding with
existing code.

Sascha

> + - enum:
> + - fsl,imx8mn-ocotp
> + - fsl,imx8mp-ocotp
> + - const: fsl,imx8mm-ocotp
> + - const: syscon
>
> reg:
> maxItems: 1
> --
> 2.17.1
>
>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |