From: Christoph Hellwig <hch@lst.de>
To: Rich Felker <dalias@libc.org>
Cc: Christoph Hellwig <hch@lst.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU
Date: Fri, 28 Aug 2020 06:24:22 +0200 [thread overview]
Message-ID: <20200828042422.GA29734@lst.de> (raw)
In-Reply-To: <20200828021152.GU3265@brightrain.aerifal.cx>
On Thu, Aug 27, 2020 at 10:11:53PM -0400, Rich Felker wrote:
> > This change broke SD card support on J2 because MMC_SPI spuriously
> > depends on HAS_DMA. It looks like it can be fixed just by removing
> > that dependency from drivers/mmc/host/Kconfig.
>
> It can't. mmp_spi_probe fails with ENOMEM, probably due to trying to
> do some DMA setup thing that's not going to be needed if the
> underlying SPI device doesn't support/use DMA.
Adding the linux-mmc and linux-spi lists, as that seems pretty odd.
next parent reply other threads:[~2020-08-28 4:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200714121856.955680-1-hch@lst.de>
[not found] ` <20200714121856.955680-10-hch@lst.de>
[not found] ` <20200828020045.GT3265@brightrain.aerifal.cx>
[not found] ` <20200828021152.GU3265@brightrain.aerifal.cx>
2020-08-28 4:24 ` Christoph Hellwig [this message]
2020-08-28 9:26 ` [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU Ulf Hansson
2020-08-28 15:09 ` Rich Felker
2020-08-29 8:31 ` Christoph Hellwig
2020-08-31 11:28 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828042422.GA29734@lst.de \
--to=hch@lst.de \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox