RE: [PATCH 2/2] mmc: renesas_sdhi: keep SCC clock active when tuning

Yoshihiro Shimoda
2020-06-09T10:41:08Z

Hi Wolfram-san,

> From: Wolfram Sang, Sent: Tuesday, June 9, 2020 6:27 AM
>
> > > + /* Tuning done, no special handling for SCC clock needed anymore */
> > > + priv->keep_scc_freq = false;
> > > +
> >
> > Setting keep_scc_freq to false is only here. But, I'm thinking
> > we should set it in some error paths like below somehow too:
> > - error paths before hs400_complete() in mmc_select_hs400().
> > - error path of mmc_execute_tuning() in mmc_retune().
>
> Hmm, I guess you are right. That would kind of spoil my approach taken
> here. Maybe we need another flag in the core like 'doing_tune' to
> supplement 'doing_retune', so or driver knows when any kind of tuning is
> going on?

Adding such a new flag is better, I think.

Best regards,
Yoshihiro Shimoda