RE: [PATCH 1/2] mmc: core: when downgrading HS400, callback into drivers earlier

Yoshihiro Shimoda
2020-06-09T10:35:11Z

Hi Wolfram-san,

> From: Wolfram Sang, Sent: Tuesday, June 9, 2020 5:41 AM
>
> Hi Shimoda-san,
>
> thank you very much for the review!
>
> > > The driver specific downgrade function makes more sense if we run it
> > > before we switch anything, not after we already switched. Otherwise some
> > > non-HS400 communication has already happened.
> > >
> > > No need to convert users. There is only one currenty which needs this
> > > change in a later patchset.
> >
> > Perhaps, should we add Fixes tag like below?
> >
> > Fixes: ba6c7ac3a2f4 ("mmc: core: more fine-grained hooks for HS400 tuning")
>
> I am not sure. While it is more correct to move the call to
> hs400_downgrade upwards, it does not really fix a bug on its own.
> Without patch 2/2 of this series, there is not really a huge difference
> when we disable the SCC the old way. For the new way, this patch is a
> prerequisite.

I got it. So, we should not add this Fixes tag.

Best regards,
Yoshihiro Shimoda