Re: [PATCH 2/2] mmc: renesas_sdhi: keep SCC clock active when tuning

Wolfram Sang
2020-06-08T21:27:05Z

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

> > + /* Tuning done, no special handling for SCC clock needed anymore */
> > + priv->keep_scc_freq = false;
> > +
>
> Setting keep_scc_freq to false is only here. But, I'm thinking
> we should set it in some error paths like below somehow too:
> - error paths before hs400_complete() in mmc_select_hs400().
> - error path of mmc_execute_tuning() in mmc_retune().

Hmm, I guess you are right. That would kind of spoil my approach taken
here. Maybe we need another flag in the core like 'doing_tune' to
supplement 'doing_retune', so or driver knows when any kind of tuning is
going on?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]