From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29B79C63697 for ; Mon, 23 Nov 2020 22:59:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1DA920715 for ; Mon, 23 Nov 2020 22:59:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="D0VqMyAB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387650AbgKWW7Y (ORCPT ); Mon, 23 Nov 2020 17:59:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:53814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733069AbgKWW7W (ORCPT ); Mon, 23 Nov 2020 17:59:22 -0500 Received: from embeddedor (187-162-31-110.static.axtel.net [187.162.31.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E16E1206D8; Mon, 23 Nov 2020 22:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606172361; bh=4xRskUD3FH91ASiM7f0FxIPbQTxm2r75mS4cvaZMGS8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D0VqMyABBGiegu2L6JrlLm6uIJTJSw05IddDRuuBJM0GK2z0gZVKcgBE2kgQUiNF1 1O+TtBOvBXmU1lXrPqtAPSEXVxDYRaerTxfASMLBNFbrypvVGvbz47WwPOqJpLaGeB 2RkMEqoJkMwNNZ1zsNnq/Vqsf0YFJIOeIP5fR3N8= Date: Mon, 23 Nov 2020 16:59:35 -0600 From: "Gustavo A. R. Silva" To: Michal Simek Cc: Adrian Hunter , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang Message-ID: <20201123225935.GW21644@embeddedor> References: <387cab3a466038aa5d1fc34b8b6a7c4f693826ea.1605896060.git.gustavoars@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Mon, Nov 23, 2020 at 08:00:35AM +0100, Michal Simek wrote: > > > On 20. 11. 20 19:37, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > > warnings by explicitly adding multiple break statements instead of > > letting the code fall through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva > > --- > > drivers/mmc/host/sdhci-of-arasan.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > > index 829ccef87426..1f7e42b6ced5 100644 > > --- a/drivers/mmc/host/sdhci-of-arasan.c > > +++ b/drivers/mmc/host/sdhci-of-arasan.c > > @@ -627,6 +627,7 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 8 Taps are available */ > > tap_max = 8; > > + break; > > default: > > break; > > } > > @@ -695,6 +696,7 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 30 Taps are available */ > > tap_max = 30; > > + break; > > default: > > break; > > } > > @@ -760,6 +762,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 8 Taps are available */ > > tap_max = 8; > > + break; > > default: > > break; > > } > > @@ -831,6 +834,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 30 Taps are available */ > > tap_max = 30; > > + break; > > default: > > break; > > } > > > > No problem with it. > > Acked-by: Michal Simek Thanks, Michal. -- Gustavo