From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9AC4C433E0 for ; Tue, 23 Feb 2021 10:17:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BCDE64E31 for ; Tue, 23 Feb 2021 10:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231812AbhBWKRx (ORCPT ); Tue, 23 Feb 2021 05:17:53 -0500 Received: from www.zeus03.de ([194.117.254.33]:51586 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231793AbhBWKRw (ORCPT ); Tue, 23 Feb 2021 05:17:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=iClqYnFJ5jndIZkRL8nZCTTZiauO AmKqtLat/qOoGxU=; b=PIVGDXxXWkutzjWcOp1fWieq4OwVT8tX5+rX3aJGjAum La60oVAEZU4YZVU7euUGtX+pkdSSem+UUiXdaaEvu5VCeywNHEoB2H2nZwqBko9/ KKFr+1yn+2YvCrF7bd7XuGV7gcTzwA03jk0+SF/uv9PDK6lth9v7C3BWhdwwYcA= Received: (qmail 2597289 invoked from network); 23 Feb 2021 11:17:11 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 Feb 2021 11:17:11 +0100 X-UD-Smtp-Session: l3s3148p1@KjmyOP67NIMgARa4RdeBASWYxunz7zkl Date: Tue, 23 Feb 2021 11:17:09 +0100 From: Wolfram Sang To: Geert Uytterhoeven Cc: Linux MMC List , Linux-Renesas , Yoshihiro Shimoda Subject: Re: [RFC PATCH v2 2/2] mmc: renesas_sdhi: do hard reset if possible Message-ID: <20210223101709.GA2486@ninjato> References: <20210222113955.7779-1-wsa+renesas@sang-engineering.com> <20210222113955.7779-3-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Geert, > "if (priv->rstc)" if the reset is made optional. Yes, that would be better. > > + priv->rstc =3D devm_reset_control_get_exclusive(&pdev->dev, NUL= L); >=20 > devm_reset_control_get_optional_exclusive()? > + missing error handling (real errors and -EPROBE_DEFER). OK. > Perhaps you want to add a "select RESET_CONTROLLER" to "config > MMC_SDHI"? Isn't "select" too strong for an optional feature? I'd think so. Thanks, Wolfram --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmA01iIACgkQFA3kzBSg KbYawBAAm5dMf2/ksXxYKM5CO/CXTDlPzDaHro7jPEYwb8gA/s8sIwNlJxN27q/F lHMT+5hd1OEIN8V/HhRAXgzdT9RP3M0B94Il95C+B9KQo0iHSv1b3BaaFPTpl+oU jAutaEbaI1bgEjODENy4dPKHkwDG7jwVEnNLjGSjpx23IEyPyppiAn3irh3/0K5m IZLq1zEFQ5jK42bUVDqETh3eg8eKyc5Q+FveQmtXxSiG0a51lPoWUZyq99+MJ47/ /XUPEuutKliJzHfXOO3ULiQ0RDczhfeNMtkJ2Bw6mundOfi7CGXWs9LEfG9cAfVZ k/CmG4tYJ6NJE/G9AcV9QRq8f3lWOo8d+5MxLaD94siO7D8Z/CE/LbftFWbETObu DHAs1y1F+sg7ae3BVZew1JgL9oYqvMso6ogR1S4AeVtwqOKO/ybS8yxk67aNetz+ WoLkoRmppNkQpwC0ytCjIXSxvjuKTTY30fdQhS+BdNfrsk/sV32fFjCeStFmGcJ9 WTrPpVPmUCmIpmq5EPJub1D38urDraUYdJZ1pJaPPV4N5yJyON9yZVR0vsdO27s5 vCj2/DinqPnZHj7PYgH/vhcCwp819/E99BFej1j2uZBWH3amuymORJwAbwoFwtpQ SOoPE3DRNlmzldxHOCUlc9dzOqky8yCMjA9cyL3puXNMsIXh7U4= =d+SM -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd--