RE: [PATCH 2/2] mmc: renesas_sdhi: use custom mask for TMIO_MASK_ALL

Yoshihiro Shimoda
2021-02-26T08:16:31Z

Hi Wolfram-san,

Thank you for the patch!

> From: Wolfram Sang, Sent: Tuesday, February 23, 2021 7:09 PM
<snip>
> diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
> index 7d5201d6a006..3b242f2e2c98 100644
> --- a/drivers/mmc/host/tmio_mmc.h
> +++ b/drivers/mmc/host/tmio_mmc.h
> @@ -100,7 +100,7 @@
>
> /* Define some IRQ masks */
> /* This is the mask used at reset by the chip */
> -#define TMIO_MASK_INIT_RCAR2 0x8b7f031d /* Initial value for R-Car Gen2+ */
> +#define TMIO_MASK_ALL_RCAR2 0x8b7f031d /* Initial value for R-Car Gen2+ */

nit: Perhaps, we also have to change the comment "Initial value"?

Anyway,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

And, I tested on my environment (r8a77951-salvator-xs.dts) and
I didn't observe any regression, so,

Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda