Re: [PATCH v2 1/3] dt-bindings: mmc: sdhci-of-dwcmhsc: Convert to yaml file

Rob Herring
2021-03-08T21:43:56Z

On Fri, Mar 05, 2021 at 09:54:20AM +0800, Shawn Lin wrote:
> This patch converts sdhci-of-dwcmshc.txt to sdhci-of-dwcmshc.yaml
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> .../devicetree/bindings/mmc/sdhci-of-dwcmshc.txt | 20 -------
> .../devicetree/bindings/mmc/sdhci-of-dwcmshc.yaml | 63 ++++++++++++++++++++++

Use the compatible string for filename.

> 2 files changed, 63 insertions(+), 20 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt
> create mode 100755 Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt b/Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt
> deleted file mode 100644
> index ee4253b..0000000
> --- a/Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -* Synopsys DesignWare Cores Mobile Storage Host Controller
> -
> -Required properties:
> -- compatible: should be one of the following:
> - "snps,dwcmshc-sdhci"
> -- reg: offset and length of the register set for the device.
> -- interrupts: a single interrupt specifier.
> -- clocks: Array of clocks required for SDHCI; requires at least one for
> - core clock.
> -- clock-names: Array of names corresponding to clocks property; shall be
> - "core" for core clock and "bus" for optional bus clock.
> -
> -Example:
> - sdhci2: sdhci@aa0000 {
> - compatible = "snps,dwcmshc-sdhci";
> - reg = <0xaa0000 0x1000>;
> - interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&emmcclk>;
> - bus-width = <8>;
> - }
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.yaml b/Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.yaml
> new file mode 100755
> index 0000000..9d717a8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/sdhci-of-dwcmshc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Synopsys Designware Mobile Storage Host Controller Binding
> +
> +maintainers:
> + - Ulf Hansson <ulf.hansson@linaro.org>
> + - Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> +
> +allOf:
> + - $ref: mmc-controller.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - snps,dwcmshc-sdhci
> +
> + reg:
> + minItems: 1
> + maxItems: 3

You need to define what each entry is.

> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
> + description:
> + Handle to "core" for core clock and "bus" for optional bus clock.

minItems: 1
items:
- description: core clock
- description: bus clock

> +
> + clock-names:
> + minItems: 1
> + maxItems: 2

Don't need maxItems here (implied by 'items' length).

> + items:
> + - const: core
> + - const: bus
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + mmc@aa0000 {
> + compatible = "snps,dwcmshc-sdhci";
> + reg = <0xaa000 0x1000>;
> + interrupts = <0 25 0x4>;
> + clocks = <&cru 17>, <&cru 18>;
> + clock-names = "core", "bus";
> + bus-width = <8>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> +...
> --
> 2.7.4
>
>
>