From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH RFT] mmc: renesas_sdhi: enable WAIT_WHILE_BUSY
Date: Fri, 9 Apr 2021 11:37:26 +0200 [thread overview]
Message-ID: <20210409093726.GA879@ninjato> (raw)
In-Reply-To: <TY2PR01MB36920CDE15B59DD55825B2E5D8739@TY2PR01MB3692.jpnprd01.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
> > + TMIO_MMC_HAVE_CBSY | MMC_CAP_WAIT_WHILE_BUSY,
>
> We should add MMC_CAP_WAIT_WHILE_BUSY to .capabilities, not .tmio_flags.
Ouch, can I have a brown paper bag, please!
>
> > .tmio_ocr_mask = MMC_VDD_32_33,
> > .capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ |
> > MMC_CAP_CMD23,
> > @@ -111,7 +111,7 @@ static const struct renesas_sdhi_of_data of_rcar_gen3_compatible = {
> > .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_CLK_ACTUAL |
> > TMIO_MMC_HAVE_CBSY | TMIO_MMC_MIN_RCAR2,
> > .capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ |
> > - MMC_CAP_CMD23,
> > + MMC_CAP_CMD23 | MMC_CAP_WAIT_WHILE_BUSY,
At least for the machines I could test, I did it correctly :/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-04-09 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:34 [PATCH RFT] mmc: renesas_sdhi: enable WAIT_WHILE_BUSY Wolfram Sang
2021-04-09 5:40 ` Yoshihiro Shimoda
2021-04-09 9:37 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409093726.GA879@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox