Re: [PATCH v2] dt-bindings: mmc: Clean-up examples to match documented bindings

Ulf Hansson
2021-05-24T14:11:27Z

On Wed, 19 May 2021 at 17:37, Rob Herring <robh@kernel.org> wrote:
>
> The "sdhci" compatible is not documented though used as a fallback in a
> few cases. It is also not supported by a Linux driver. Just remove the
> example as part of ridding examples of undocumented bindings.
>
> The "brcm,bcm43xx-fmac" compatible is also not documented. Update the
> example to use one of the correct ones, "brcm,bcm4329-fmac", instead and
> use a device class based nodename.
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Applied for next, thanks!

Kind regards
Uffe

> ---
> v2:
> - Also fix "brcm,bcm43xx-fmac" example
>
> .../bindings/mmc/mmc-controller.yaml | 20 ++-----------------
> 1 file changed, 2 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index e141330c1114..646ae768d625 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -357,22 +357,6 @@ dependencies:
> additionalProperties: true
>
> examples:
> - - |
> - mmc@ab000000 {
> - compatible = "sdhci";
> - reg = <0xab000000 0x200>;
> - interrupts = <23>;
> - bus-width = <4>;
> - cd-gpios = <&gpio 69 0>;
> - cd-inverted;
> - wp-gpios = <&gpio 70 0>;
> - max-frequency = <50000000>;
> - keep-power-in-suspend;
> - wakeup-source;
> - mmc-pwrseq = <&sdhci0_pwrseq>;
> - clk-phase-sd-hs = <63>, <72>;
> - };
> -
> - |
> mmc3: mmc@1c12000 {
> #address-cells = <1>;
> @@ -385,9 +369,9 @@ examples:
> non-removable;
> mmc-pwrseq = <&sdhci0_pwrseq>;
>
> - brcmf: bcrmf@1 {
> + brcmf: wifi@1 {
> reg = <1>;
> - compatible = "brcm,bcm43xx-fmac";
> + compatible = "brcm,bcm4329-fmac";
> interrupt-parent = <&pio>;
> interrupts = <10 8>;
> interrupt-names = "host-wake";
> --
> 2.27.0
>