Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: jgg@ziepe.ca, leon@kernel.org, m.szyprowski@samsung.com,
	robin.murphy@arm.com, ulf.hansson@linaro.org
Cc: torvalds@linux-foundation.org, khilman@baylibre.com,
	jbrunet@baylibre.com, linux-mmc@vger.kernel.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: [PATCH RFC 0/2] scatterlist: add I/O variant of sg_pcopy & sg_copy and use them
Date: Mon, 28 Jun 2021 14:34:09 +0200	[thread overview]
Message-ID: <20210628123411.119778-1-narmstrong@baylibre.com> (raw)

A local variant of sg_copy_buffer has been introduced in the meson-gx mmc driver [1] after
a mempcy optimization, fixing the iomem buffer manipulation and the reported system crash [2].

But, the fix is suboptimal in terms of performace/ugliness [3] and a proper I/O variant of
sg_copy_buffer should be added and used instead.

[1] https://lore.kernel.org/r/20210609150230.9291-1-narmstrong@baylibre.com
[2] https://lore.kernel.org/r/acb244ad-0759-5a96-c659-5c23003d3dcd@samsung.com
[3] https://lore.kernel.org/r/CAPDyKFrLSMpPJOgd5e4B1x3Vwfg4q23zgy4ESc8EmFL2MnyK7g@mail.gmail.com

Neil Armstrong (2):
  scatterlist: add I/O variant of sg_pcopy & sg_copy
  mmc: meson-gx: use sg_copy_to/from_io instead of local version

 drivers/mmc/host/meson-gx-mmc.c |  53 +++-----------
 include/linux/scatterlist.h     |  14 ++++
 lib/scatterlist.c               | 119 ++++++++++++++++++++++++++++++++
 3 files changed, 143 insertions(+), 43 deletions(-)

-- 
2.25.1


             reply	other threads:[~2021-06-28 12:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 12:34 Neil Armstrong [this message]
2021-06-28 12:34 ` [PATCH RFC 1/2] scatterlist: add I/O variant of sg_pcopy & sg_copy Neil Armstrong
2021-06-28 13:40   ` Robin Murphy
2021-06-28 12:34 ` [PATCH RFC 2/2] mmc: meson-gx: use sg_copy_to/from_io instead of local version Neil Armstrong
2021-06-28 13:44   ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628123411.119778-1-narmstrong@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=jbrunet@baylibre.com \
    --cc=jgg@ziepe.ca \
    --cc=khilman@baylibre.com \
    --cc=leon@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robin.murphy@arm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox