From: Jason Lai <jasonlai.genesyslogic@gmail.com>
To: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>
Cc: Jason Lai <jasonlai.genesyslogic@gmail.com>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Ben Chuang <benchuanggli@gmail.com>
Subject: Re: [PATCH 2/4] mmc: core: Prepare to support SD UHS-II cards
Date: Fri, 2 Jul 2021 16:00:22 +0800 [thread overview]
Message-ID: <20210702080022.11235-1-jasonlai.genesyslogic@gmail.com> (raw)
In-Reply-To: <20210225170352.76872-3-ulf.hansson@linaro.org>
Hi Ulf,
You added one bit definition 'MMC_CAP2_SD_UHS2' in struct mmc_host.caps2.
But there already had a bit definition 'MMC_CAP_UHS2' in struct mmc_host.caps.
#define MMC_CAP_UHS2 (1 << 26) /* Host supports UHS2 mode */
This bit was first appearred in [RFC PATCH V3 01/21] mmc: add UHS-II related definitions in public headers.
These 2 bits seems to be defined for the same purpose, which one should I use?
kindly regards,
Jason Lai
---
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index a001ad2f5f23..0a777caaf7f3 100644
--- a/include/linux/mmc/host.h
+++ b/include/linux/mmc/host.h
@@ -377,6 +393,7 @@ struct mmc_host {
MMC_CAP2_HS200_1_2V_SDR)
#define MMC_CAP2_SD_EXP (1 << 7) /* SD express via PCIe */
#define MMC_CAP2_SD_EXP_1_2V (1 << 8) /* SD express 1.2V */
+#define MMC_CAP2_SD_UHS2 (1 << 9) /* SD UHS-II support */
#define MMC_CAP2_CD_ACTIVE_HIGH (1 << 10) /* Card-detect signal active high */
#define MMC_CAP2_RO_ACTIVE_HIGH (1 << 11) /* Write-protect signal active high */
#define MMC_CAP2_NO_PRESCAN_POWERUP (1 << 14) /* Don't power up before scan */
next prev parent reply other threads:[~2021-07-02 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 17:03 [PATCH 0/4] mmc: core: Preparations to support SD UHS-II cards Ulf Hansson
2021-02-25 17:03 ` [PATCH 1/4] mmc: core: Cleanup printing of speed mode at card insertion Ulf Hansson
2021-02-25 17:03 ` [PATCH 2/4] mmc: core: Prepare to support SD UHS-II cards Ulf Hansson
2021-07-02 8:00 ` Jason Lai [this message]
2021-07-02 8:31 ` Ulf Hansson
2021-02-25 17:03 ` [PATCH 3/4] mmc: core: Announce successful insertion of an SD UHS-II card Ulf Hansson
2021-02-25 17:03 ` [PATCH 4/4] mmc: core: Extend support for mmc regulators with a vqmmc2 Ulf Hansson
2021-03-31 9:57 ` [PATCH 0/4] mmc: core: Preparations to support SD UHS-II cards Ulf Hansson
2021-03-31 10:26 ` ReniusChen[陳建宏]
2021-03-31 10:31 ` Ulf Hansson
-- strict thread matches above, loose matches on Subject: below --
2021-06-24 16:30 [PATCH] mmc: sdhci: Fix warning message when accessing RPMB in HS400 mode Al Cooper
[not found] ` <CAG0XXUGrmHY_2koaFTkUH8kozZ8B5Z_eafJMm+92-NP4oSE7yA@mail.gmail.com>
[not found] ` <CAG0XXUH6zVaHGatn6rjMMOzEkkwSdFBseGyGSik8a6cQLJvX2Q@mail.gmail.com>
2021-06-28 2:08 ` [PATCH 2/4] mmc: core: Prepare to support SD UHS-II cards Lai Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702080022.11235-1-jasonlai.genesyslogic@gmail.com \
--to=jasonlai.genesyslogic@gmail.com \
--cc=benchuanggli@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=takahiro.akashi@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).