Re: [PATCH v3 1/8] scsi/sd: add error handling support for add_disk()

Luis Chamberlain
2021-09-13T17:21:56Z

On Tue, Sep 07, 2021 at 09:29:07AM +0800, Ming Lei wrote:
> On Mon, Aug 30, 2021 at 02:25:31PM -0700, Luis Chamberlain wrote:
> > We never checked for errors on add_disk() as this function
> > returned void. Now that this is fixed, use the shiny new
> > error handling.
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> > ---
> > drivers/scsi/sd.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> > index 610ebba0d66e..8c1273fff23e 100644
> > --- a/drivers/scsi/sd.c
> > +++ b/drivers/scsi/sd.c
> > @@ -3487,7 +3487,11 @@ static int sd_probe(struct device *dev)
> > pm_runtime_set_autosuspend_delay(dev,
> > sdp->host->hostt->rpm_autosuspend_delay);
> > }
> > - device_add_disk(dev, gd, NULL);
> > +
> > + error = device_add_disk(dev, gd, NULL);
> > + if (error)
> > + goto out_free_index;
> > +
>
> The error handling is actually wrong, see
>
> https://lore.kernel.org/linux-scsi/c93f3010-13c9-e07f-1458-b6b47a27057b@acm.org/T/#t
>
> Maybe you can base on that patch.

Done, thanks!

Luis