Re: [PATCH v2 3/3] blk-crypto: show crypto capabilities in sysfs

Eric Biggers
2021-11-30T07:40:22Z

On Tue, Nov 30, 2021 at 07:49:54AM +0100, Hannes Reinecke wrote:
> > - "modes" is a sub-subdirectory, since there may be multiple supported
> > crypto modes, and sysfs is supposed to have one value per file.
> >
> Why do you have a sub-directory here?
> From what I can see, that subdirectory just contains the supported modes, so
> wouldn't it be easier to create individual files like 'mode_<modename>'
> instead of a subdirectory?

It is a group of attributes, so it makes sense to group them together rather
than put them all in the parent directory alongside other attributes. It also
allows the use of proper names like "AES-256-XTS" rather than weird names like
"mode_AES-256-XTS" or "mode_aes_256_xts".

- Eric