From: Wenchao Chen <wenchao.chen666@gmail.com>
To: ulf.hansson@linaro.org
Cc: baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
megoo.tang@gmail.com, lzx.stg@gmail.com
Subject: [PATCH] mmc: host: Fix data stomping during mmc recovery
Date: Fri, 16 Sep 2022 17:05:06 +0800 [thread overview]
Message-ID: <20220916090506.10662-1-wenchao.chen666@gmail.com> (raw)
From: Wenchao Chen <wenchao.chen@unisoc.com>
The block device uses multiple queues to access emmc. There will be up to 3
requests in the hsq of the host. The current code will check whether there
is a request doing recovery before entering the queue, but it will not check
whether there is a request when the lock is issued. The request is in recovery
mode. If there is a request in recovery, then a read and write request is
initiated at this time, and the conflict between the request and the recovery
request will cause the data to be trampled.
Signed-off-by: Wenchao Chen <wenchao.chen@unisoc.com>
---
drivers/mmc/host/mmc_hsq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mmc_hsq.c b/drivers/mmc/host/mmc_hsq.c
index a5e05ed0fda3..9d35453e7371 100644
--- a/drivers/mmc/host/mmc_hsq.c
+++ b/drivers/mmc/host/mmc_hsq.c
@@ -34,7 +34,7 @@ static void mmc_hsq_pump_requests(struct mmc_hsq *hsq)
spin_lock_irqsave(&hsq->lock, flags);
/* Make sure we are not already running a request now */
- if (hsq->mrq) {
+ if (hsq->mrq || hsq->recovery_halt) {
spin_unlock_irqrestore(&hsq->lock, flags);
return;
}
--
2.17.1
next reply other threads:[~2022-09-16 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 9:05 Wenchao Chen [this message]
2022-09-20 9:32 ` [PATCH] mmc: host: Fix data stomping during mmc recovery Ulf Hansson
2022-09-20 10:19 ` Adrian Hunter
2022-09-27 5:45 ` 陈文超
2022-09-27 12:13 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220916090506.10662-1-wenchao.chen666@gmail.com \
--to=wenchao.chen666@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lzx.stg@gmail.com \
--cc=megoo.tang@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox