From: Dinh Nguyen <dinguyen@kernel.org>
To: jh80.chung@samsung.com
Cc: dinguyen@kernel.org, ulf.hansson@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCHv2 0/3] mmc: socfpga: add method to configure clk-phase
Date: Thu, 22 Sep 2022 17:03:05 -0500 [thread overview]
Message-ID: <20220922220308.609422-1-dinguyen@kernel.org> (raw)
Hi,
This is version 2 of the patchset to configure the clk-phase for the
SDMMC controller on SoCFPGA platforms.
Updates from v1:
- Documented "altr,sysmgr-syscon" binding
- Cleaned up dw_mci_socfpga_priv_init() to get the "clk-phase-sd-hs"
from the DTS. Ulf Hanson recommended using mmc_of_parse_clk_phase() in
this function, however, I found that using mmc_of_parse_clk_phase() is a
bit more complicated than just reading the "clk-phase-sd-hs" from the
DTS. Here are the reasons:
- The call to mmc_of_parse_clk_phase() takes the struct mmc_host
*host structure, and in the dw_mmc driver, and this structure
does not get populated until at the very end of the dw_mci_probe
function, after dw_mci_init_slot() gets called.
- Also, in order to correctly extract the
phase_map.phase[timing], we need to wait until set_ios() is
called in order to get the host->timing parameter so it can be used for
the clock phase array.
Dinh Nguyen (3):
dt-bindings: mmc: synopsys-dw-mshc: document "altr,sysmgr-syscon"
arm64: dts: socfpga: Add clk-phase-sd-hs property to the sdmmc node
mmc: dw_mmc-pltfm: socfpga: add method to configure clk-phase
.../bindings/mmc/synopsys-dw-mshc.yaml | 8 ++++
.../boot/dts/altera/socfpga_stratix10.dtsi | 1 +
.../dts/altera/socfpga_stratix10_socdk.dts | 1 +
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 1 +
.../boot/dts/intel/socfpga_agilex_socdk.dts | 1 +
.../boot/dts/intel/socfpga_n5x_socdk.dts | 1 +
drivers/mmc/host/dw_mmc-pltfm.c | 41 ++++++++++++++++++-
7 files changed, 53 insertions(+), 1 deletion(-)
--
2.25.1
next reply other threads:[~2022-09-22 22:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 22:03 Dinh Nguyen [this message]
2022-09-22 22:03 ` [PATCHv2 1/3] dt-bindings: mmc: synopsys-dw-mshc: document "altr,sysmgr-syscon" Dinh Nguyen
2022-09-23 17:49 ` Krzysztof Kozlowski
2022-09-22 22:03 ` [PATCHv2 2/3] arm64: dts: socfpga: Add clk-phase-sd-hs property to the sdmmc node Dinh Nguyen
2022-09-22 22:03 ` [PATCHv2 3/3] mmc: dw_mmc-pltfm: socfpga: add method to configure clk-phase Dinh Nguyen
2022-09-23 17:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922220308.609422-1-dinguyen@kernel.org \
--to=dinguyen@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox