From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Alex Dubov <oakad@yahoo.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-mmc@vger.kernel.org
Subject: [PATCH 14/14] mmc: wbsd: Replace kmap_atomic() with kmap_local_page()
Date: Wed, 5 Oct 2022 13:19:51 +0300 [thread overview]
Message-ID: <20221005101951.3165-15-adrian.hunter@intel.com> (raw)
In-Reply-To: <20221005101951.3165-1-adrian.hunter@intel.com>
kmap_local_page() is equivalent to kmap_atomic() except that it does not
disable page faults or preemption. Where possible kmap_local_page() is
preferred to kmap_atomic() - refer kernel highmem documentation.
In this case, there is no need to disable page faults or preemption, so
replace kmap_atomic() with kmap_local_page(), and, correspondingly,
kunmap_atomic() with kunmap_local().
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
drivers/mmc/host/wbsd.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c
index 67ecd342fe5f..2219144c166a 100644
--- a/drivers/mmc/host/wbsd.c
+++ b/drivers/mmc/host/wbsd.c
@@ -267,7 +267,7 @@ static inline int wbsd_next_sg(struct wbsd_host *host)
static inline char *wbsd_map_sg(struct wbsd_host *host)
{
- return kmap_atomic(sg_page(host->cur_sg)) + host->cur_sg->offset;
+ return kmap_local_page(sg_page(host->cur_sg)) + host->cur_sg->offset;
}
static inline void wbsd_sg_to_dma(struct wbsd_host *host, struct mmc_data *data)
@@ -439,7 +439,7 @@ static void wbsd_empty_fifo(struct wbsd_host *host)
* End of scatter list entry?
*/
if (host->remain == 0) {
- kunmap_atomic(buffer);
+ kunmap_local(buffer);
/*
* Get next entry. Check if last.
*/
@@ -451,7 +451,7 @@ static void wbsd_empty_fifo(struct wbsd_host *host)
}
}
}
- kunmap_atomic(buffer);
+ kunmap_local(buffer);
/*
* This is a very dirty hack to solve a
@@ -505,7 +505,7 @@ static void wbsd_fill_fifo(struct wbsd_host *host)
* End of scatter list entry?
*/
if (host->remain == 0) {
- kunmap_atomic(buffer);
+ kunmap_local(buffer);
/*
* Get next entry. Check if last.
*/
@@ -517,7 +517,7 @@ static void wbsd_fill_fifo(struct wbsd_host *host)
}
}
}
- kunmap_atomic(buffer);
+ kunmap_local(buffer);
/*
* The controller stops sending interrupts for
--
2.25.1
next prev parent reply other threads:[~2022-10-05 10:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 10:19 [PATCH 00/14] mmc: Replace kmap_atomic() with kmap_local_page() Adrian Hunter
2022-10-05 10:19 ` [PATCH 01/14] mmc: sdhci: Remove local_irq_{save,restore}() around k[un]map_atomic() Adrian Hunter
2022-10-05 10:19 ` [PATCH 02/14] mmc: sdhci: Remove local_irq_{save,restore}() around sg_miter_{next,stop}() Adrian Hunter
2022-10-05 10:19 ` [PATCH 03/14] mmc: sdhci: Replace kmap_atomic() with kmap_local_page() Adrian Hunter
2022-10-06 7:03 ` Avri Altman
2022-10-06 7:23 ` Adrian Hunter
2022-10-05 10:19 ` [PATCH 04/14] mmc: bcm2835: Remove local_irq_{save,restore}() around k[un]map_atomic() Adrian Hunter
2022-10-05 10:19 ` [PATCH 05/14] mmc: bcm2835: Remove local_irq_{save,restore}() around sg_miter_{next,stop}() Adrian Hunter
2022-10-05 10:19 ` [PATCH 06/14] mmc: bcm2835: Replace kmap_atomic() with kmap_local_page() Adrian Hunter
2022-10-05 10:19 ` [PATCH 07/14] mmc: mmc_test: Remove local_irq_{save,restore}() around sg_copy_{from,to}_buffer() Adrian Hunter
2022-10-05 10:19 ` [PATCH 08/14] mmc: tifm_sd: Remove local_irq_{save,restore}() around tifm_sd_transfer_data() Adrian Hunter
2022-10-05 10:19 ` [PATCH 09/14] mmc: tifm_sd: Remove local_irq_{save,restore}() around tifm_sd_bounce_block() Adrian Hunter
2022-10-05 10:19 ` [PATCH 10/14] mmc: tifm_sd: Replace kmap_atomic() with kmap_local_page() Adrian Hunter
2022-10-05 10:19 ` [PATCH 11/14] mmc: tmio_mmc_core: Remove local_irq_{save,restore}() around k[un]map_atomic() Adrian Hunter
2022-10-31 19:36 ` Wolfram Sang
2022-11-02 12:06 ` Wolfram Sang
2022-10-05 10:19 ` [PATCH 12/14] mmc: tmio_mmc_core: Replace kmap_atomic() with kmap_local_page() Adrian Hunter
2022-10-31 19:38 ` Wolfram Sang
2022-10-05 10:19 ` [PATCH 13/14] mmc: au1xmmc: " Adrian Hunter
2022-10-05 10:19 ` Adrian Hunter [this message]
2022-10-24 17:11 ` [PATCH 00/14] mmc: " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005101951.3165-15-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=f.fainelli@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=stefan.wahren@i2se.com \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).