Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>
Cc: <linux-omap@vger.kernel.org>
Subject: [PATCH v3 06/12] mmc: omap_hsmmc: fix deferred probing
Date: Sat, 17 Jun 2023 23:36:16 +0300	[thread overview]
Message-ID: <20230617203622.6812-7-s.shtylyov@omp.ru> (raw)
In-Reply-To: <20230617203622.6812-1-s.shtylyov@omp.ru>

The driver overrides the error codes returned by platform_get_irq() to
-ENXIO, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.

Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
Changes in version 2:
- refreshed the patch.

 drivers/mmc/host/omap_hsmmc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 517dde777413..1e0f2d7774bd 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1791,9 +1791,11 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
 	}
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	irq = platform_get_irq(pdev, 0);
-	if (res == NULL || irq < 0)
+	if (!res)
 		return -ENXIO;
+	irq = platform_get_irq(pdev, 0);
+	if (irq < 0)
+		return irq;
 
 	base = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(base))
-- 
2.26.3


  parent reply	other threads:[~2023-06-17 20:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-17 20:36 [PATCH v3 00/12] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
2023-06-17 20:36 ` [PATCH v3 01/12] mmc: bcm2835: fix deferred probing Sergey Shtylyov
2023-06-17 20:36 ` [PATCH v3 02/12] mmc: meson-gx: " Sergey Shtylyov
2023-06-17 20:36 ` [PATCH v3 03/12] mmc: mtk-sd: " Sergey Shtylyov
2023-06-17 20:36 ` [PATCH v3 04/12] mmc: mvsdio: " Sergey Shtylyov
2023-06-17 20:36 ` [PATCH v3 05/12] mmc: omap: " Sergey Shtylyov
2023-06-17 20:36 ` Sergey Shtylyov [this message]
2023-06-17 20:36 ` [PATCH v3 07/12] mmc: owl: " Sergey Shtylyov
2023-06-17 20:36 ` [PATCH v3 08/12] mmc: sdhci-acpi: " Sergey Shtylyov
2023-06-17 20:36 ` [PATCH v3 09/12] mmc: sdhci-spear: " Sergey Shtylyov
2023-06-17 20:36 ` [PATCH v3 10/12] mmc: sh_mmcif: " Sergey Shtylyov
2023-06-17 20:36 ` [PATCH v3 11/12] mmc: sunxi: " Sergey Shtylyov
2023-06-17 20:36 ` [PATCH v3 12/12] mmc: usdhi60rol0: " Sergey Shtylyov
2023-06-19 11:43 ` [PATCH v3 00/12] Fix deferred probing in the MMC/SD drivers Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230617203622.6812-7-s.shtylyov@omp.ru \
    --to=s.shtylyov@omp.ru \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox