From: "Rong.Chen" <Rong.Chen@amlogic.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Rong Chen <rong.chen@amlogic.com>
Subject: [PATCH] mmc: meson-gx: Remove setting of CMD_CFG_ERROR
Date: Wed, 27 Sep 2023 15:25:44 +0800 [thread overview]
Message-ID: <20230927072544.764285-1-Rong.Chen@amlogic.com> (raw)
From: Rong Chen <rong.chen@amlogic.com>
Setting bit CMD_CFG_ERROR has non effects on previous controllers.
However, it will cause an IRQ and stop working on latest controllers,
This bit is used for selecting SG LINK of data address.
Don't set the bit CMD_CFG_ERROR anymore to resolve this issuse.
Therefore, remove this setting.
Signed-off-by: Rong Chen <rong.chen@amlogic.com>
---
drivers/mmc/host/meson-gx-mmc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 9837dab096e6..c7c067b9415a 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -801,7 +801,6 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd)
cmd_cfg |= FIELD_PREP(CMD_CFG_CMD_INDEX_MASK, cmd->opcode);
cmd_cfg |= CMD_CFG_OWNER; /* owned by CPU */
- cmd_cfg |= CMD_CFG_ERROR; /* stop in case of error */
meson_mmc_set_response_bits(cmd, &cmd_cfg);
--
2.42.0
next reply other threads:[~2023-09-27 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 7:25 Rong.Chen [this message]
2023-09-27 7:43 ` [PATCH] mmc: meson-gx: Remove setting of CMD_CFG_ERROR Jerome Brunet
[not found] ` <202309271651027503622@amlogic.com>
2023-09-27 9:30 ` Jerome Brunet
2023-10-10 11:55 ` Rong Chen
2023-10-26 7:40 ` Rong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927072544.764285-1-Rong.Chen@amlogic.com \
--to=rong.chen@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox