Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
To: ulf.hansson@linaro.org
Cc: adrian.hunter@intel.com, CLoehle@hyperstone.com,
	brauner@kernel.org, axboe@kernel.dk,
	victor.shih@genesyslogic.com.tw, f.fainelli@gmail.com,
	asuk4.q@gmail.com, yibin.ding@unisoc.com,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	edson.drosdeck@gmail.com
Subject: [PATCH] mmc: block: Use octal for file permissions
Date: Thu, 19 Oct 2023 16:57:52 -0300	[thread overview]
Message-ID: <20231019195752.62692-1-edson.drosdeck@gmail.com> (raw)

Octal permissions are preferred as stated in
Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions
with octal permissions when creating the files.

Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
---
 drivers/mmc/core/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index b5b414a71e0b..edb653d8fbfa 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -2916,7 +2916,7 @@ static void mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md)
 
 	if (mmc_card_mmc(card)) {
 		md->ext_csd_dentry =
-			debugfs_create_file("ext_csd", S_IRUSR, root, card,
+			debugfs_create_file("ext_csd", 0400, root, card,
 					    &mmc_dbg_ext_csd_fops);
 	}
 }
-- 
2.39.2


             reply	other threads:[~2023-10-19 19:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 19:57 Edson Juliano Drosdeck [this message]
2023-10-23 11:42 ` [PATCH] mmc: block: Use octal for file permissions Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231019195752.62692-1-edson.drosdeck@gmail.com \
    --to=edson.drosdeck@gmail.com \
    --cc=CLoehle@hyperstone.com \
    --cc=adrian.hunter@intel.com \
    --cc=asuk4.q@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=victor.shih@genesyslogic.com.tw \
    --cc=yibin.ding@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox