From: Jorge Ramirez-Ortiz <jorge@foundries.io>
To: jorge@foundries.io, adrian.hunter@intel.com, Avri.Altman@wdc.com,
ulf.hansson@linaro.org, christian.loehle@arm.com,
ricardo@foundries.io
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: [PATCH] mmc: rpmb: do not force a retune before RPMB switch
Date: Mon, 11 Dec 2023 17:55:00 +0100 [thread overview]
Message-ID: <20231211165500.310097-1-jorge@foundries.io> (raw)
Requesting a retune before switching to the RPMB partition has been
observed to cause CRC errors on the RPMB reads (-EILSEQ).
Since RPMB reads can not be retried, the clients would be directly
affected by the errors.
This commit disables the retune request prior to switching to the RPMB
partition: mmc_retune_pause() no longer triggers a retune before the
pause period begins.
This was verified with the sdhci-of-arasan driver (ZynqMP) configured
for HS200 using two separate eMMC cards (DG4064 and 064GB2). In both
cases, the error was easy to reproduce triggering every few tenths of
reads.
Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
Acked-by: Avri Altman <avri.altman@wdc.com>
---
v2:
mmc_retune_pause() no longer can trigger a retune.
Keeping Avri Altman Acked-by since they are functionally equivalent.
v1:
modify mmc_retune_pause to optionally trigger a retune.
drivers/mmc/core/host.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 096093f7be00..ed44920e92df 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -119,13 +119,12 @@ void mmc_retune_enable(struct mmc_host *host)
/*
* Pause re-tuning for a small set of operations. The pause begins after the
- * next command and after first doing re-tuning.
+ * next command.
*/
void mmc_retune_pause(struct mmc_host *host)
{
if (!host->retune_paused) {
host->retune_paused = 1;
- mmc_retune_needed(host);
mmc_retune_hold(host);
}
}
--
2.34.1
next reply other threads:[~2023-12-11 16:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 16:55 Jorge Ramirez-Ortiz [this message]
2024-01-03 8:08 ` [PATCH] mmc: rpmb: do not force a retune before RPMB switch Adrian Hunter
2024-01-03 10:35 ` Ulf Hansson
-- strict thread matches above, loose matches on Subject: below --
2023-12-04 17:22 Jorge Ramirez-Ortiz
2023-12-04 17:52 ` Christian Loehle
2023-12-04 18:10 ` Jorge Ramirez-Ortiz, Foundries
2023-12-11 16:17 ` Adrian Hunter
2023-12-04 15:01 Jorge Ramirez-Ortiz
2023-12-04 16:22 ` Avri Altman
2023-12-04 17:58 ` Avri Altman
2023-12-04 18:14 ` Jorge Ramirez-Ortiz, Foundries
2023-12-05 16:10 ` Jorge Ramirez-Ortiz, Foundries
2023-12-05 20:12 ` Adrian Hunter
2023-12-05 20:14 ` Adrian Hunter
2023-12-06 7:02 ` Avri Altman
2023-12-06 10:00 ` Jorge Ramirez-Ortiz, Foundries
2023-12-11 8:00 ` Jorge Ramirez-Ortiz, Foundries
2023-12-11 10:25 ` Adrian Hunter
2023-12-11 11:06 ` Jorge Ramirez-Ortiz, Foundries
2023-12-11 11:32 ` Adrian Hunter
2023-12-11 15:05 ` Jorge Ramirez-Ortiz, Foundries
2023-12-14 9:15 ` Adrian Hunter
2023-12-14 11:16 ` Jorge Ramirez-Ortiz, Foundries
2024-01-02 10:41 ` Jorge Ramirez-Ortiz, Foundries
2024-01-02 19:01 ` Adrian Hunter
2024-01-02 22:01 ` Jorge Ramirez-Ortiz, Foundries
2024-01-03 8:03 ` Adrian Hunter
2024-01-03 9:20 ` Jorge Ramirez-Ortiz, Foundries
2024-01-04 18:34 ` Adrian Hunter
2024-01-05 8:49 ` Jorge Ramirez-Ortiz, Foundries
2024-01-05 13:00 ` Michal Simek
2023-12-11 8:03 ` Adrian Hunter
2024-01-02 19:02 ` Adrian Hunter
2024-01-03 8:08 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211165500.310097-1-jorge@foundries.io \
--to=jorge@foundries.io \
--cc=Avri.Altman@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=christian.loehle@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ricardo@foundries.io \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox