Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Colin Ian King <colin.i.king@gmail.com>
To: Pierre Ossman <pierre@ossman.eu>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Nathan Chancellor <nathan@kernel.org>,
	linux-mmc@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Subject: [PATCH][next][V2] mmc: wbsd: remove redundant assignment to variable id and id check
Date: Tue,  6 Feb 2024 17:12:45 +0000	[thread overview]
Message-ID: <20240206171245.2421538-1-colin.i.king@gmail.com> (raw)

The variable id is being initialized with a value that is never
read, it is being re-assigned later on. The initialization is
redundant and can be removed.

As noted by Ulf Hansson the unknown hardware check id != 0xFFFF
is also redundant and can be removed too.

Cleans up clang scan build warning:
drivers/mmc/host/wbsd.c:1287:4: warning: Value stored to 'id'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
V2: As suggested by Ulf Hansson, also remove the redundant
    hardware check for id != 0xFFFF.
---
 drivers/mmc/host/wbsd.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c
index 001a468bc149..4b32421d9f6d 100644
--- a/drivers/mmc/host/wbsd.c
+++ b/drivers/mmc/host/wbsd.c
@@ -1284,8 +1284,6 @@ static int wbsd_scan(struct wbsd_host *host)
 			continue;
 
 		for (j = 0; j < ARRAY_SIZE(unlock_codes); j++) {
-			id = 0xFFFF;
-
 			host->config = config_ports[i];
 			host->unlock_code = unlock_codes[j];
 
@@ -1306,11 +1304,6 @@ static int wbsd_scan(struct wbsd_host *host)
 					return 0;
 				}
 			}
-
-			if (id != 0xFFFF) {
-				DBG("Unknown hardware (id %x) found at %x\n",
-					id, config_ports[i]);
-			}
 		}
 
 		release_region(config_ports[i], 2);
-- 
2.39.2


             reply	other threads:[~2024-02-06 17:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06 17:12 Colin Ian King [this message]
2024-02-13 16:45 ` [PATCH][next][V2] mmc: wbsd: remove redundant assignment to variable id and id check Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240206171245.2421538-1-colin.i.king@gmail.com \
    --to=colin.i.king@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=pierre@ossman.eu \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox