From: Christoph Hellwig <hch@lst.de>
To: iommu@lists.linux.dev
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Robin Murphy <robin.murphy@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org,
linux-mmc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org
Subject: remove the dma_set_{max_seg_size,seg_boundary,min_align_mask} return value v2
Date: Sat, 24 Aug 2024 05:49:11 +0200 [thread overview]
Message-ID: <20240824034925.1163244-1-hch@lst.de> (raw)
Hi all,
the above three functions can only return errors if the bus code failed
to allocate the dma_parms structure, which is a grave error that won't
get us far. Thus remove the pointless return values, that so far have
fortunately been mostly ignored, but which the cleanup brigade now wants
to check for for no good reason.
Changes since v1:
- fix SCSI to not call dma_set_max_seg_size and dma_set_seg_boundary
unconditionally
Diffstat:
drivers/accel/qaic/qaic_drv.c | 4 --
drivers/dma/idma64.c | 4 --
drivers/dma/pl330.c | 5 ---
drivers/dma/qcom/bam_dma.c | 6 ----
drivers/dma/sh/rcar-dmac.c | 4 --
drivers/dma/ste_dma40.c | 6 ----
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ----
drivers/media/common/videobuf2/videobuf2-dma-contig.c | 3 --
drivers/media/pci/intel/ipu6/ipu6.c | 4 --
drivers/mmc/host/mmci_stm32_sdmmc.c | 3 +-
drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ----
drivers/scsi/lpfc/lpfc_init.c | 7 -----
drivers/scsi/scsi_lib.c | 11 ++++++-
include/linux/dma-mapping.h | 25 +++++++-----------
14 files changed, 32 insertions(+), 62 deletions(-)
next reply other threads:[~2024-08-24 3:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 3:49 Christoph Hellwig [this message]
2024-08-24 3:49 ` [PATCH 1/4] scsi: check that busses support the DMA API before setting dma parameters Christoph Hellwig
2024-08-27 12:19 ` Robin Murphy
2024-08-24 3:49 ` [PATCH 2/4] dma-mapping: don't return errors from dma_set_min_align_mask Christoph Hellwig
2024-08-24 3:49 ` [PATCH 3/4] dma-mapping: don't return errors from dma_set_seg_boundary Christoph Hellwig
2024-08-24 3:49 ` [PATCH 4/4] dma-mapping: don't return errors from dma_set_max_seg_size Christoph Hellwig
2024-08-26 11:36 ` Ulf Hansson
2024-08-29 0:57 ` remove the dma_set_{max_seg_size,seg_boundary,min_align_mask} return value v2 Martin K. Petersen
2024-08-29 4:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240824034925.1163244-1-hch@lst.de \
--to=hch@lst.de \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox