From: Erick Shepherd <erick.shepherd@ni.com>
To: <linux-kernel@vger.kernel.org>
Cc: <linux-mmc@vger.kernel.org>, <york.yang@csr.com>,
<ulf.hansson@linaro.org>, Erick Shepherd <erick.shepherd@ni.com>
Subject: [RFC PATCH 1/2] mmc: Update sdhci tune function to return errors
Date: Mon, 27 Jan 2025 16:36:53 -0600 [thread overview]
Message-ID: <20250127223654.290904-1-erick.shepherd@ni.com> (raw)
Updates the sdhci_execute_tuning function to return the error code
that was returned by the __sdhci_execute_tuning function.
Previously this code was only stored in host->tuning_err and not
actually returned.
Signed-off-by: Erick Shepherd <erick.shepherd@ni.com>
---
drivers/mmc/host/sdhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index f4a7733a8ad2..b35b8917fa1e 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2967,7 +2967,8 @@ int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
sdhci_start_tuning(host);
- host->tuning_err = __sdhci_execute_tuning(host, opcode);
+ err = __sdhci_execute_tuning(host, opcode);
+ host->tuning_err = err;
sdhci_end_tuning(host);
out:
--
2.43.0
next reply other threads:[~2025-01-27 23:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 22:36 Erick Shepherd [this message]
2025-01-27 22:36 ` [RFC PATCH 2/2] mmc: Allow tuning to be skipped during card init Erick Shepherd
2025-01-28 16:04 ` Judith Mendez
2025-01-28 22:20 ` Erick Shepherd
2025-02-03 13:49 ` Ulf Hansson
2025-02-03 13:42 ` [RFC PATCH 1/2] mmc: Update sdhci tune function to return errors Ulf Hansson
2025-02-06 21:07 ` Erick Shepherd
2025-02-06 23:53 ` Judith Mendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127223654.290904-1-erick.shepherd@ni.com \
--to=erick.shepherd@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=york.yang@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox