From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-mmc@vger.kernel.org
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Subject: [RFC PATCH 04/11] mmc: rename mmc_can_poweroff_notify() to mmc_card_can_poweroff_notify()
Date: Tue, 1 Apr 2025 11:58:40 +0200 [thread overview]
Message-ID: <20250401095847.29271-5-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20250401095847.29271-1-wsa+renesas@sang-engineering.com>
mmc_can_* functions sometimes relate to the card and sometimes to the host.
Make it obvious by renaming this function to include 'card'.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/core/mmc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 2b63eb608489..8911b2206c45 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -2013,7 +2013,7 @@ static int mmc_sleep(struct mmc_host *host)
return err;
}
-static bool mmc_can_poweroff_notify(const struct mmc_card *card)
+static bool mmc_card_can_poweroff_notify(const struct mmc_card *card)
{
return card &&
mmc_card_mmc(card) &&
@@ -2137,7 +2137,7 @@ static int _mmc_suspend(struct mmc_host *host, enum mmc_poweroff_type pm_type)
goto out;
pr_info("%s: reason %d, may_notify %d\n", mmc_hostname(host), pm_type, mmc_may_poweroff_notify(host, pm_type));
- if (mmc_can_poweroff_notify(host->card) &&
+ if (mmc_card_can_poweroff_notify(host->card) &&
mmc_may_poweroff_notify(host, pm_type))
err = mmc_poweroff_notify(host->card, notify_type);
else if (mmc_can_sleep(host->card))
@@ -2217,7 +2217,7 @@ static int mmc_shutdown(struct mmc_host *host)
* In a specific case for poweroff notify, we need to resume the card
* before we can shutdown it properly.
*/
- if (mmc_can_poweroff_notify(host->card) &&
+ if (mmc_card_can_poweroff_notify(host->card) &&
!mmc_may_poweroff_notify(host, MMC_POWEROFF_SUSPEND))
err = _mmc_resume(host);
--
2.47.2
next prev parent reply other threads:[~2025-04-01 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 9:58 [RFC PATCH 00/11] mmc: rename mmc_can_* functions Wolfram Sang
2025-04-01 9:58 ` [RFC PATCH 01/11] mmc: rename mmc_can_discard() to mmc_card_can_discard() Wolfram Sang
2025-04-01 9:58 ` [RFC PATCH 02/11] mmc: rename mmc_can_erase() to mmc_card_can_erase() Wolfram Sang
2025-04-01 9:58 ` [RFC PATCH 03/11] mmc: rename mmc_can_ext_csd() to mmc_card_can_ext_csd() Wolfram Sang
2025-04-01 9:58 ` Wolfram Sang [this message]
2025-04-01 9:58 ` [RFC PATCH 05/11] mmc: rename mmc_can_reset() to mmc_card_can_reset() Wolfram Sang
2025-04-01 9:58 ` [RFC PATCH 06/11] mmc: rename mmc_can_sanitize() to mmc_card_can_sanitize() Wolfram Sang
2025-04-01 9:58 ` [RFC PATCH 07/11] mmc: rename mmc_can_secure_erase_trim() to mmc_card_can_secure_erase_trim() Wolfram Sang
2025-04-01 9:58 ` [RFC PATCH 08/11] mmc: rename mmc_can_sleep() to mmc_card_can_sleep() Wolfram Sang
2025-04-01 9:58 ` [RFC PATCH 09/11] mmc: rename mmc_can_trim() to mmc_card_can_trim() Wolfram Sang
2025-04-01 9:58 ` [RFC PATCH 10/11] mmc: rename mmc_can_gpio_cd() to mmc_host_can_gpio_cd() Wolfram Sang
2025-04-01 9:58 ` [RFC PATCH 11/11] mmc: rename mmc_can_gpio_ro() to mmc_host_can_gpio_ro() Wolfram Sang
2025-04-22 15:43 ` [RFC PATCH 00/11] mmc: rename mmc_can_* functions Ulf Hansson
2025-04-22 15:59 ` Wolfram Sang
2025-04-23 20:29 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250401095847.29271-5-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox