From: Yixun Lan <dlan@gentoo.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] mmc: sdhci-of-k1: Fix error code in probe()
Date: Tue, 27 May 2025 06:58:41 +0000 [thread overview]
Message-ID: <20250527065841-GYB55693@gentoo> (raw)
In-Reply-To: <aDVTtQdXVtRhxOrb@stanley.mountain>
Hi Dan,
On 08:55 Tue 27 May , Dan Carpenter wrote:
> If spacemit_sdhci_get_clocks() fails, then propagate the error code.
> Don't return success.
>
> Fixes: e5502d15b0f3 ("mmc: sdhci-of-k1: add support for SpacemiT K1 SoC")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/mmc/host/sdhci-of-k1.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-k1.c b/drivers/mmc/host/sdhci-of-k1.c
> index 6880d3e9ab62..2e5da7c5834c 100644
> --- a/drivers/mmc/host/sdhci-of-k1.c
> +++ b/drivers/mmc/host/sdhci-of-k1.c
> @@ -276,7 +276,8 @@ static int spacemit_sdhci_probe(struct platform_device *pdev)
>
> host->mmc->caps |= MMC_CAP_NEED_RSP_BUSY;
>
> - if (spacemit_sdhci_get_clocks(dev, pltfm_host))
> + ret = spacemit_sdhci_get_clocks(dev, pltfm_host);
> + if (ret)
> goto err_pltfm;
>
> ret = sdhci_add_host(host);
> --
> 2.47.2
>
Thanks for catching this..
Reviewed-by: Yixun Lan <dlan@gentoo.org>
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2025-05-27 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 5:55 [PATCH next] mmc: sdhci-of-k1: Fix error code in probe() Dan Carpenter
2025-05-27 6:58 ` Yixun Lan [this message]
2025-05-28 11:42 ` Adrian Hunter
2025-06-09 14:25 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527065841-GYB55693@gentoo \
--to=dlan@gentoo.org \
--cc=adrian.hunter@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=spacemit@lists.linux.dev \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox