From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E919D9476 for ; Fri, 30 May 2025 00:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748564480; cv=none; b=XnO3/7C1DRGXH0oMm9xStGfocL4vvROBacTtJk5QqxcIxHFRsJSyqwpKcCPhr8x4yTy8r1W1tbasJQqsG4LO5Utg91x/O9GRnxlNO9QOjL3AV8/k0HDm2OaMCs03r1F9s+oazveqmacB6jrP2TE8XLymL9CJ1/rMIUEERFxJHmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748564480; c=relaxed/simple; bh=QCJGh2gpvjzWowZKYSIeJr94U1LVQOCrLrk7Waw0xQk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wx8ouwKNIKVG07zLWsnevOg/4yViHhWDxOaWOiTmxrmTy5ISSmRAgLmittXiK7M7tNRXUi3fiU2ZlDWV/8mhLRtMK+ww3zBp1x+1weONQs2jfjoED4wGZ5Jc5d5XieAX7wydagfVNZBsh3iU5LOxLItr4bGVLaIGxK1DabHAa0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AbpjgXnG; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AbpjgXnG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748564477; x=1780100477; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QCJGh2gpvjzWowZKYSIeJr94U1LVQOCrLrk7Waw0xQk=; b=AbpjgXnGLpFRbx+5KJBW2lwjO9W/Y5t8+dUGtdm+PS/ABzCr87Ulsw4V Op/N5BIczIjiqcz6fk1DLy6vUJc3v5AO60rZj/wnzn7OdPtQhoMuVzvjb SnkWT/2jyFipbsWr1lYWpnz2WboP6te5IGJpGMZB58qtU1YUGS1oXxgaB vCZbFkbhmx1nvm000IWk05ubYydDs7yjNn0acc+LgdvVjbW6C1X8zcyID E22c7W6VFkXQRNDavvyRVNKTmYi7uS11bofHn7kyT6pdN+nMi2GdapXdn Hr9XyNiY2dlDFJMClK+QTPfZTyFHxN/fabip7M1Ue4EVKgoZZ+Peb5SZu A==; X-CSE-ConnectionGUID: 2ZX4fhnGSF6EY4qGGBZt3A== X-CSE-MsgGUID: yxVe5zrpTx2pI9FEBubVdg== X-IronPort-AV: E=McAfee;i="6700,10204,11448"; a="60909387" X-IronPort-AV: E=Sophos;i="6.16,194,1744095600"; d="scan'208";a="60909387" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2025 17:21:16 -0700 X-CSE-ConnectionGUID: XGuUdJJUToCEHhToPx17FQ== X-CSE-MsgGUID: E9SzGb0jR62AuTCLx2SkLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,194,1744095600"; d="scan'208";a="144699021" Received: from lkp-server01.sh.intel.com (HELO 1992f890471c) ([10.239.97.150]) by fmviesa009.fm.intel.com with ESMTP; 29 May 2025 17:21:13 -0700 Received: from kbuild by 1992f890471c with local (Exim 4.96) (envelope-from ) id 1uKnUl-000XDU-0j; Fri, 30 May 2025 00:21:11 +0000 Date: Fri, 30 May 2025 08:20:16 +0800 From: kernel test robot To: Binbin Zhou , Binbin Zhou , Huacai Chen , Ulf Hansson , Adrian Hunter Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-mmc@vger.kernel.org, Andrew Jeffery , Hu Ziji Subject: Re: [PATCH v2 32/35] mmc: sdhci-xenon: Drop the use of sdhci_pltfm_free() Message-ID: <202505300815.tjQRQD6z-lkp@intel.com> References: Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Binbin, kernel test robot noticed the following build warnings: [auto build test WARNING on d2c6acff6386f43ed307822454b970c831c48f1b] url: https://github.com/intel-lab-lkp/linux/commits/Binbin-Zhou/mmc-sdhci-Use-devm_mmc_alloc_host-helper/20250529-212928 base: d2c6acff6386f43ed307822454b970c831c48f1b patch link: https://lore.kernel.org/r/b79920fa8bff8f7cf2f407863846446344d2eab7.1748515612.git.zhoubinbin%40loongson.cn patch subject: [PATCH v2 32/35] mmc: sdhci-xenon: Drop the use of sdhci_pltfm_free() config: arm-randconfig-004-20250530 (https://download.01.org/0day-ci/archive/20250530/202505300815.tjQRQD6z-lkp@intel.com/config) compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250530/202505300815.tjQRQD6z-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202505300815.tjQRQD6z-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/mmc/host/sdhci-xenon.c:536:59: warning: variable 'err' is uninitialized when used here [-Wuninitialized] 536 | dev_err(&pdev->dev, "Failed to setup input clk: %d\n", err); | ^~~ include/linux/dev_printk.h:154:65: note: expanded from macro 'dev_err' 154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~ include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ drivers/mmc/host/sdhci-xenon.c:515:9: note: initialize the variable 'err' to silence this warning 515 | int err; | ^ | = 0 1 warning generated. vim +/err +536 drivers/mmc/host/sdhci-xenon.c 3a3748dba881ed Hu Ziji 2017-03-30 508 3a3748dba881ed Hu Ziji 2017-03-30 509 static int xenon_probe(struct platform_device *pdev) 3a3748dba881ed Hu Ziji 2017-03-30 510 { 3a3748dba881ed Hu Ziji 2017-03-30 511 struct sdhci_pltfm_host *pltfm_host; 1542488031deed Marcin Wojtas 2020-12-04 512 struct device *dev = &pdev->dev; 3a3748dba881ed Hu Ziji 2017-03-30 513 struct sdhci_host *host; bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 514 struct xenon_priv *priv; 3a3748dba881ed Hu Ziji 2017-03-30 515 int err; 3a3748dba881ed Hu Ziji 2017-03-30 516 3a3748dba881ed Hu Ziji 2017-03-30 517 host = sdhci_pltfm_init(pdev, &sdhci_xenon_pdata, 3a3748dba881ed Hu Ziji 2017-03-30 518 sizeof(struct xenon_priv)); 3a3748dba881ed Hu Ziji 2017-03-30 519 if (IS_ERR(host)) 3a3748dba881ed Hu Ziji 2017-03-30 520 return PTR_ERR(host); 3a3748dba881ed Hu Ziji 2017-03-30 521 3a3748dba881ed Hu Ziji 2017-03-30 522 pltfm_host = sdhci_priv(host); bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 523 priv = sdhci_pltfm_priv(pltfm_host); 3a3748dba881ed Hu Ziji 2017-03-30 524 f75fda3730728e Marcin Wojtas 2020-12-04 525 priv->hw_version = (unsigned long)device_get_match_data(&pdev->dev); f75fda3730728e Marcin Wojtas 2020-12-04 526 3a3748dba881ed Hu Ziji 2017-03-30 527 /* 3a3748dba881ed Hu Ziji 2017-03-30 528 * Link Xenon specific mmc_host_ops function, 3a3748dba881ed Hu Ziji 2017-03-30 529 * to replace standard ones in sdhci_ops. 3a3748dba881ed Hu Ziji 2017-03-30 530 */ 3a3748dba881ed Hu Ziji 2017-03-30 531 xenon_replace_mmc_host_ops(host); 3a3748dba881ed Hu Ziji 2017-03-30 532 1542488031deed Marcin Wojtas 2020-12-04 533 if (dev->of_node) { 3a3748dba881ed Hu Ziji 2017-03-30 534 pltfm_host->clk = devm_clk_get(&pdev->dev, "core"); 3a3748dba881ed Hu Ziji 2017-03-30 535 if (IS_ERR(pltfm_host->clk)) { 3a3748dba881ed Hu Ziji 2017-03-30 @536 dev_err(&pdev->dev, "Failed to setup input clk: %d\n", err); 6773eb1cf68bcb Binbin Zhou 2025-05-29 537 return PTR_ERR(pltfm_host->clk); 3a3748dba881ed Hu Ziji 2017-03-30 538 } 3a3748dba881ed Hu Ziji 2017-03-30 539 err = clk_prepare_enable(pltfm_host->clk); 3a3748dba881ed Hu Ziji 2017-03-30 540 if (err) 6773eb1cf68bcb Binbin Zhou 2025-05-29 541 return err; 3a3748dba881ed Hu Ziji 2017-03-30 542 bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 543 priv->axi_clk = devm_clk_get(&pdev->dev, "axi"); bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 544 if (IS_ERR(priv->axi_clk)) { bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 545 err = PTR_ERR(priv->axi_clk); bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 546 if (err == -EPROBE_DEFER) bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 547 goto err_clk; bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 548 } else { bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 549 err = clk_prepare_enable(priv->axi_clk); 3a3748dba881ed Hu Ziji 2017-03-30 550 if (err) 3a3748dba881ed Hu Ziji 2017-03-30 551 goto err_clk; bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 552 } 1542488031deed Marcin Wojtas 2020-12-04 553 } bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 554 bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 555 err = mmc_of_parse(host->mmc); bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 556 if (err) bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 557 goto err_clk_axi; 3a3748dba881ed Hu Ziji 2017-03-30 558 f29bf660bf4137 Marcin Wojtas 2020-12-04 559 sdhci_get_property(pdev); 3a3748dba881ed Hu Ziji 2017-03-30 560 3a3748dba881ed Hu Ziji 2017-03-30 561 xenon_set_acg(host, false); 3a3748dba881ed Hu Ziji 2017-03-30 562 f29bf660bf4137 Marcin Wojtas 2020-12-04 563 /* Xenon specific parameters parse */ f29bf660bf4137 Marcin Wojtas 2020-12-04 564 err = xenon_probe_params(pdev); 3a3748dba881ed Hu Ziji 2017-03-30 565 if (err) bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 566 goto err_clk_axi; 3a3748dba881ed Hu Ziji 2017-03-30 567 3a3748dba881ed Hu Ziji 2017-03-30 568 err = xenon_sdhc_prepare(host); 3a3748dba881ed Hu Ziji 2017-03-30 569 if (err) bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 570 goto err_clk_axi; 3a3748dba881ed Hu Ziji 2017-03-30 571 a027b2c5fed788 Zhoujie Wu 2017-08-29 572 pm_runtime_get_noresume(&pdev->dev); a027b2c5fed788 Zhoujie Wu 2017-08-29 573 pm_runtime_set_active(&pdev->dev); a027b2c5fed788 Zhoujie Wu 2017-08-29 574 pm_runtime_set_autosuspend_delay(&pdev->dev, 50); a027b2c5fed788 Zhoujie Wu 2017-08-29 575 pm_runtime_use_autosuspend(&pdev->dev); a027b2c5fed788 Zhoujie Wu 2017-08-29 576 pm_runtime_enable(&pdev->dev); a027b2c5fed788 Zhoujie Wu 2017-08-29 577 pm_suspend_ignore_children(&pdev->dev, 1); a027b2c5fed788 Zhoujie Wu 2017-08-29 578 3a3748dba881ed Hu Ziji 2017-03-30 579 err = sdhci_add_host(host); 3a3748dba881ed Hu Ziji 2017-03-30 580 if (err) 3a3748dba881ed Hu Ziji 2017-03-30 581 goto remove_sdhc; 3a3748dba881ed Hu Ziji 2017-03-30 582 a027b2c5fed788 Zhoujie Wu 2017-08-29 583 pm_runtime_put_autosuspend(&pdev->dev); 5d40213347480e Elad Nachman 2024-01-04 584 /* 5d40213347480e Elad Nachman 2024-01-04 585 * If we previously detected AC5 with over 2GB of memory, 5d40213347480e Elad Nachman 2024-01-04 586 * then we disable ADMA and 64-bit DMA. 5d40213347480e Elad Nachman 2024-01-04 587 * This means generic SDHCI driver has set the DMA mask to 5d40213347480e Elad Nachman 2024-01-04 588 * 32-bit. Since DDR starts at 0x2_0000_0000, we must use 5d40213347480e Elad Nachman 2024-01-04 589 * 34-bit DMA mask to access this DDR memory: 5d40213347480e Elad Nachman 2024-01-04 590 */ 5d40213347480e Elad Nachman 2024-01-04 591 if (priv->hw_version == XENON_AC5 && 5d40213347480e Elad Nachman 2024-01-04 592 host->quirks2 & SDHCI_QUIRK2_BROKEN_64_BIT_DMA) 5d40213347480e Elad Nachman 2024-01-04 593 dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); a027b2c5fed788 Zhoujie Wu 2017-08-29 594 3a3748dba881ed Hu Ziji 2017-03-30 595 return 0; 3a3748dba881ed Hu Ziji 2017-03-30 596 3a3748dba881ed Hu Ziji 2017-03-30 597 remove_sdhc: a027b2c5fed788 Zhoujie Wu 2017-08-29 598 pm_runtime_disable(&pdev->dev); a027b2c5fed788 Zhoujie Wu 2017-08-29 599 pm_runtime_put_noidle(&pdev->dev); 3a3748dba881ed Hu Ziji 2017-03-30 600 xenon_sdhc_unprepare(host); bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 601 err_clk_axi: bb16ea1742c8f3 Gregory CLEMENT 2017-10-02 602 clk_disable_unprepare(priv->axi_clk); 3a3748dba881ed Hu Ziji 2017-03-30 603 err_clk: 3a3748dba881ed Hu Ziji 2017-03-30 604 clk_disable_unprepare(pltfm_host->clk); 3a3748dba881ed Hu Ziji 2017-03-30 605 return err; 3a3748dba881ed Hu Ziji 2017-03-30 606 } 3a3748dba881ed Hu Ziji 2017-03-30 607 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki