From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23BFA374287 for ; Thu, 21 Aug 2025 20:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806909; cv=none; b=BqY08wqJhFWVzUZvK7teL3BJUS2YMKqgcyc4wyH0ih3b3qJdQMXA8Gfdk4G3A4WbJlbDBlWiEnmO6dU+q8Te3nGMzdkTse58TpfWHbf8lRbzX7VWNyNSBtPTPN/zYyc6W8ZW5fJckMg+0wNHmSW/XLz6qG8WeVs9AVeD+18Io8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806909; c=relaxed/simple; bh=bq2gWh1hWRAlT57D1zXSNbOueAtiEim7ETzHNFHN/Ro=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o5Xw3LJdGQVt2Z0JgPdRTyKD+bKi7487d3v/RxHdzzWqWi0wS8UDEt6/cZi8S/Y9RMY4V5/i1EvC6rN3/LWipEq5SGgqH5sMu0akau9bRMZ5hWelFoRZ2QgbT/jy0EwIfa5h5XC8TnibKkhwiZys5jE/54BS020yV1pnyHq8kzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fdA0r21N; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fdA0r21N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755806906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yR/3u5W37RASrGsn/s3pQVQ78UUgH4ByCavV3b4UG3M=; b=fdA0r21N38x+v2UQLIZ9WgOzWypzyF/gGbyMtQrNNeIBCBkAH7jv3EsB2igOSoB1bm5R0u zwSo3epyzhY1kDhsD1gVzR3BS/SSw7j4pFu5qqw1G9nF2GyfOSX3B4rDzNGsDz+YRLxAib yGhcCmMtiIyZzytyFFCB9WOUCQp/uaY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-p8lZlOXMPx2zB48tVaXbAw-1; Thu, 21 Aug 2025 16:08:25 -0400 X-MC-Unique: p8lZlOXMPx2zB48tVaXbAw-1 X-Mimecast-MFC-AGG-ID: p8lZlOXMPx2zB48tVaXbAw_1755806904 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45a15fd6b45so10809175e9.1 for ; Thu, 21 Aug 2025 13:08:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755806904; x=1756411704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yR/3u5W37RASrGsn/s3pQVQ78UUgH4ByCavV3b4UG3M=; b=wtmx3j0KwJIdozFJrbTPIjppOYdUgM2LFFR7y2EP+4qjnvECD3a5CSf8dgTeCwQFUY conn5tWUnrytbwv78PzoByKAndGOvviKAcuuWduyEnjQacke4OAi0ea7O35+NYberx1s X28FMHyFiSdr7/0HT+7cry4fiUxdrM4Yh5Dj+qmcQiLswYNCTPPKmiDxghP+cfKz6Xbx fho3lzvBrSBltzRHrwG0sgOFfAp/+POlp91jmeT8NTjrBvAJ1XRLqFG3imqIokNpgOD0 W462A342X7SlhRSS69VqDLdefLTIfC33Np2PardUpgpeVwUNNhO1xf8CqhOeDffaTroD RPsw== X-Forwarded-Encrypted: i=1; AJvYcCVwYOoGHervvuU6UPQpkojcMA9R1IFrCwLIldSgV3mj6FDhc7PK93iFDHl2Zvi3+FlnQBpvzOCl2vQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxuMBRlsHH6U97BK2raM6MXXzhxj2Zvgf98/255p+EDRTTFJ1FI M2/7GHbHr9ZPPM0dDfzLrND2GqmLOwc0WOMsOJuJaLhN/qASKdlCrMC/23Io4Rs2ZS7qjb2rfRK O357PxLOsV7KVn7Y2Txs0IUpLNzzoTrY2tRkPXut4A/KakT3/uu/H8itjXXBeEA== X-Gm-Gg: ASbGncugKBqmGHltwiHi/k3Nu6DiRKYt4gHiuc6oA9cRLXG9sjFZpqMfbXBOoe0K/fY 5TXJqDTe8SmPKOBzyWYTX3+HnEcR4Q++sAx4H0IbsrNq/WJ2r939FkvTJvFirsfTBPSvjQpjCR0 tzuCXh5ethc3ptDNksoG9ewAifdZHI/O8yELHrM8IjiA/8iSv+xeFB8ufXe7LjqOzYnlTTmGFLQ vnp0G1tANcYXNR0aaOE5Unh/RC/3CIVadrPC3uaLN7fMberT8LaBl9Lak/9UH5v0KdUwIPrR0dc AUSH+0/dBvaXA3XvbQmM/k98z2a1L3IVnLDwJC/jFuXyAlYYhh29egF6KRDBXdl1snrgHkd1NOS 5lCLdYGfMTy/mi+wee+5U4A== X-Received: by 2002:a05:6000:310e:b0:3c3:5406:12b0 with SMTP id ffacd0b85a97d-3c5d53b40abmr247286f8f.30.1755806903632; Thu, 21 Aug 2025 13:08:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+53ePp4gOBoZK5+aLlST4uu6G3xHtHBUa0vmdrbtPfJ4bf44S3Zn2IpCr0m84pAneAOD81g== X-Received: by 2002:a05:6000:310e:b0:3c3:5406:12b0 with SMTP id ffacd0b85a97d-3c5d53b40abmr247245f8f.30.1755806903113; Thu, 21 Aug 2025 13:08:23 -0700 (PDT) Received: from localhost (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3c0771c1708sm13032145f8f.38.2025.08.21.13.08.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 13:08:22 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Maxim Levitsky , Alex Dubov , Ulf Hansson , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH RFC 27/35] memstick: drop nth_page() usage within SG entry Date: Thu, 21 Aug 2025 22:06:53 +0200 Message-ID: <20250821200701.1329277-28-david@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821200701.1329277-1-david@redhat.com> References: <20250821200701.1329277-1-david@redhat.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It's no longer required to use nth_page() when iterating pages within a single SG entry, so let's drop the nth_page() usage. Cc: Maxim Levitsky Cc: Alex Dubov Cc: Ulf Hansson Signed-off-by: David Hildenbrand --- drivers/memstick/host/jmb38x_ms.c | 3 +-- drivers/memstick/host/tifm_ms.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c index cddddb3a5a27f..c5e71d39ffd51 100644 --- a/drivers/memstick/host/jmb38x_ms.c +++ b/drivers/memstick/host/jmb38x_ms.c @@ -317,8 +317,7 @@ static int jmb38x_ms_transfer_data(struct jmb38x_ms_host *host) unsigned int p_off; if (host->req->long_data) { - pg = nth_page(sg_page(&host->req->sg), - off >> PAGE_SHIFT); + pg = sg_page(&host->req->sg) + off / PAGE_SIZE; p_off = offset_in_page(off); p_cnt = PAGE_SIZE - p_off; p_cnt = min(p_cnt, length); diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c index db7f3a088fb09..0d64184ca10a9 100644 --- a/drivers/memstick/host/tifm_ms.c +++ b/drivers/memstick/host/tifm_ms.c @@ -201,8 +201,7 @@ static unsigned int tifm_ms_transfer_data(struct tifm_ms *host) unsigned int p_off; if (host->req->long_data) { - pg = nth_page(sg_page(&host->req->sg), - off >> PAGE_SHIFT); + pg = sg_page(&host->req->sg) + off / PAGE_SIZE; p_off = offset_in_page(off); p_cnt = PAGE_SIZE - p_off; p_cnt = min(p_cnt, length); -- 2.50.1