[PATCH] mmc: sdhci: Stop advertising the driver in dmesg

[PATCH] mmc: sdhci: Stop advertising the driver in dmesg

[Linus Walleij]

As much as we have grown used to seeing this message on
every kernel boot, it does not add any technical value.

Demote the init banner to pr_debug() like other similar
messages in the driver and drop the copyright message
altogether.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/mmc/host/sdhci.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index ac7e11f37af71fa5a70eb579fd812227b9347f83..001802a3aa202c4d8f185ff4924838579ee44c4f 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -4999,9 +4999,8 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
 
 static int __init sdhci_drv_init(void)
 {
-	pr_info(DRIVER_NAME
-		": Secure Digital Host Controller Interface driver\n");
-	pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
+	pr_debug(DRIVER_NAME
+		 ": Secure Digital Host Controller Interface driver\n");
 
 	return 0;
 }

---
base-commit: fd94619c43360eb44d28bd3ef326a4f85c600a07
change-id: 20251007-mmc-no-advert-8f5646c44dd6

Best regards,
-- 
Linus Walleij <linus.walleij@linaro.org>

Re: [PATCH] mmc: sdhci: Stop advertising the driver in dmesg

[Ulf Hansson]

On Tue, 7 Oct 2025 at 15:15, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> As much as we have grown used to seeing this message on
> every kernel boot, it does not add any technical value.
>
> Demote the init banner to pr_debug() like other similar
> messages in the driver and drop the copyright message
> altogether.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/mmc/host/sdhci.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ac7e11f37af71fa5a70eb579fd812227b9347f83..001802a3aa202c4d8f185ff4924838579ee44c4f 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -4999,9 +4999,8 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
>
>  static int __init sdhci_drv_init(void)
>  {
> -       pr_info(DRIVER_NAME
> -               ": Secure Digital Host Controller Interface driver\n");
> -       pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
> +       pr_debug(DRIVER_NAME
> +                ": Secure Digital Host Controller Interface driver\n");
>

Why do we need a print at all during module init?

Typically sdhci drivers end up printing a message at the log level if
they succeed to probe in __sdhci_add_host() - along with the other
error/debug messages during ->probe(). That seems sufficient to me,
but I'm not sure what other people think.

Kind regards
Uffe

>         return 0;
>  }
>
> ---
> base-commit: fd94619c43360eb44d28bd3ef326a4f85c600a07
> change-id: 20251007-mmc-no-advert-8f5646c44dd6
>
> Best regards,
> --
> Linus Walleij <linus.walleij@linaro.org>
>

Re: [PATCH] mmc: sdhci: Stop advertising the driver in dmesg

[Adrian Hunter]

On 07/10/2025 17:20, Ulf Hansson wrote:
> On Tue, 7 Oct 2025 at 15:15, Linus Walleij <linus.walleij@linaro.org> wrote:
>>
>> As much as we have grown used to seeing this message on
>> every kernel boot, it does not add any technical value.
>>
>> Demote the init banner to pr_debug() like other similar
>> messages in the driver and drop the copyright message
>> altogether.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>>  drivers/mmc/host/sdhci.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>> index ac7e11f37af71fa5a70eb579fd812227b9347f83..001802a3aa202c4d8f185ff4924838579ee44c4f 100644
>> --- a/drivers/mmc/host/sdhci.c
>> +++ b/drivers/mmc/host/sdhci.c
>> @@ -4999,9 +4999,8 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
>>
>>  static int __init sdhci_drv_init(void)
>>  {
>> -       pr_info(DRIVER_NAME
>> -               ": Secure Digital Host Controller Interface driver\n");
>> -       pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
>> +       pr_debug(DRIVER_NAME
>> +                ": Secure Digital Host Controller Interface driver\n");
>>
> 
> Why do we need a print at all during module init?
> 
> Typically sdhci drivers end up printing a message at the log level if
> they succeed to probe in __sdhci_add_host() - along with the other
> error/debug messages during ->probe(). That seems sufficient to me,
> but I'm not sure what other people think.

I tend to agree.  In include/linux/module.h it says
/* Each module must use one module_init(). */
but I am not sure that is true.  If not, maybe sdhci_drv_init()
and sdhci_drv_exit() could be removed.