From: Kamal Dasu <kamal.dasu@broadcom.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kees Cook <kees@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
William Zhang <william.zhang@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kamal Dasu <kamal.dasu@broadcom.com>
Subject: [PATCH v4 0/4] mmc: Add pstore backend for crash dump storage on eMMC
Date: Fri, 20 Mar 2026 16:32:45 -0400 [thread overview]
Message-ID: <20260320203249.1965044-1-kamal.dasu@broadcom.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=[UTF-8], Size: 4350 bytes --]
This series adds mmcpstore, a pstore backend driver that enables
persistent storage of kernel crash logs on eMMC devices. When the
kernel panics, pstore captures the kmsg dump and writes it directly
to a dedicated MMC partition using polled I/O with interrupts
disabled.
Changes since v3:
- Fixed kernel-doc warnings reported by kernel test robot:
- Added missing @param descriptions for sdhci_panic_prepare(),
sdhci_panic_poll_completion(), sdhci_panic_complete() (patch 2)
- Added missing @sect_offset param doc for
mmcpstore_do_request_internal() (patch 4)
- Fixed kernel-doc function name mismatch: mmcpstore_read() ->
mmcpstore_read_zone() (patch 4)
- Added missing @disk param doc for mmcpstore_card_add() (patch 4)
- Removed unused 'offset_bytes' variable in
mmcpstore_register_for_card() (patch 4)
Changes since v2 (RFC):
- Rebased onto v7.0-rc — no longer reverts any existing MMC core
or SDHCI changes (v1/v2 accidentally reverted recent upstream
commits due to being based on an older tree)
- Removed all erase/bitmap tracking logic — MMC/eMMC is managed
flash and does not need erase-before-write; the pstore_zone
framework handles zone management internally
- Uses standard MMC core request path (mmc_start_request) instead
of hand-building mmc_request structs; panic-context I/O is
handled through proper mmc_host_ops callbacks rather than ad-hoc
code in the driver
- Added panic-context ops to mmc_host_ops and sdhci_ops for clean
separation of panic and normal I/O paths
- Fixed deadlocks caused by spinlock contention during panic
(lockless mmc_panic_claim_host using WRITE_ONCE)
- Fixed data corruption in pstore recovery (zlib_inflate failures)
by letting the normal sdhci_request() path run instead of a
custom panic request handler
- Added PM suspend/resume support with eMMC re-initialization
- Supports module loading or builtin loading of the driver
- Added MAINTAINERS entry
- Split into 4-patch series for reviewability
The series is structured as follows:
Patch 1 adds panic-context operations to struct mmc_host_ops and a
lockless mmc_panic_claim_host() for use during kernel panic when
other CPUs are stopped and may hold locks.
Patch 2 implements these panic-context operations in the SDHCI host
controller driver: draining in-flight requests, polling for
completion, and making the command retry path panic-safe.
Patch 3 adds mmc_blk_get_card_by_name() helper to look up an
mmc_card from a block device name, used by the mmcpstore module
path for card discovery.
Patch 4 adds the mmcpstore driver itself, which registers with the
pstore_blk framework and handles panic writes, PM suspend/resume,
and dual-path registration (direct probe hook for builtin,
mmc_blk_get_card_by_name() for module). Also adds probe/remove
hooks in block.c and declarations in block.h for the builtin path.
Tested on Broadcom STB platforms (ARM64) with SDHCI controllers,
verified panic dump recovery across multiple panic/reboot cycles
with kmsg, pmsg, and console pstore.
Previous submissions and related work:
RFC v1: https://lore.kernel.org/linux-mmc/20221216212738.7928-1-kdasu.kdev@gmail.com/
RFC v2: https://lore.kernel.org/linux-mmc/20221222185948.12717-1-kdasu.kdev@gmail.com/
v3: https://lore.kernel.org/linux-mmc/20260319185705.1516950-1-kamal.dasu@broadcom.com/
Marvell MMC pstore attempt (2020):
https://lore.kernel.org/linux-mmc/20201207115753.21728-1-bbudiredla@marvell.com/
pstore/blk documentation:
https://www.kernel.org/doc/html/latest/admin-guide/pstore-blk.html
Kamal Dasu (4):
mmc: core: Add panic-context host operations for pstore backends
mmc: sdhci: Implement panic-context write support
mmc: block: Add helper to look up mmc_card by device name
mmc: core: Add MMC pstore backend driver
MAINTAINERS | 6 +
drivers/mmc/core/Kconfig | 12 +
drivers/mmc/core/Makefile | 1 +
drivers/mmc/core/block.c | 56 ++
drivers/mmc/core/block.h | 18 +
drivers/mmc/core/core.c | 23 +
drivers/mmc/core/mmcpstore.c | 1519 ++++++++++++++++++++++++++++++++++
drivers/mmc/host/sdhci.c | 169 +++-
drivers/mmc/host/sdhci.h | 6 +
include/linux/mmc/host.h | 12 +
10 files changed, 1818 insertions(+), 4 deletions(-)
create mode 100644 drivers/mmc/core/mmcpstore.c
--
2.34.1
next reply other threads:[~2026-03-20 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 20:32 Kamal Dasu [this message]
2026-03-20 20:32 ` [PATCH v4 1/4] mmc: core: Add panic-context host operations for pstore backends Kamal Dasu
2026-03-20 20:32 ` [PATCH v4 2/4] mmc: sdhci: Implement panic-context write support Kamal Dasu
2026-03-20 20:32 ` [PATCH v4 3/4] mmc: block: Add helper to look up mmc_card by device name Kamal Dasu
2026-03-20 20:32 ` [PATCH v4 4/4] mmc: core: Add MMC pstore backend driver Kamal Dasu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320203249.1965044-1-kamal.dasu@broadcom.com \
--to=kamal.dasu@broadcom.com \
--cc=adrian.hunter@intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox