From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E87A53A380C for ; Thu, 3 Sep 2026 22:59:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788476374; cv=none; b=NPu+O/1TXrnGeeIR6QgLkmrjhVTlwbRYwxcr5NWWAa9UQ761wWdVml76uCMi5a1c60/47ofJMp9jRdChQYR2AKZtyU+4Z7nJbjDgwjgK4MUPOswXtKusZggtccOuyGj3Qh8rMDonHqnW1bjsbEoilY0mcQLRDsnIzAeh4LKfbag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788476374; c=relaxed/simple; bh=dBm6wiR4NCMuszCPNIsVX9WFUcZFQlUHejOmhcoyT0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M8mo4Jg6rPcS79zE0RD0KgNerB0ZezHGXafaNag6jKrPOYvHmH4on+LLN5I4HcTEkZlAMMWK1bRFD7qUnsAQSn9/wb1tjkkJiyxunIGO4NnvE/0WvQP/qrynA5k2/toTYLl7DRl3Ddm4uhXSuOrotGJdtUmaXWdjHWwYysZWxTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-484392e3d33so244690f8f.2 for ; Thu, 03 Sep 2026 15:59:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788476369; x=1789081169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=F1SiDePVmO2z41UWzhMW/dfuGDGSD2CkgizPnd7ksWA=; b=sZgySqVvjScrTLQMPYphRNkZKxaVg3IR60YZBBu5ujF9qMUs1sgA4KJzaUcodqO3Tp 5V9mHIG33t1AuFsTLsdF/HDh+aZp3wUZq0CsFsz2ZwnkRTh/JajoB/7Yw6vspWQLFtmj P9ri752lTselggcaTLdt8QIGhgrpo/AQr2BfmI2o3mUQFVGS3WWUkMtfT7B0hVInnuNW MG94SA0m5SVgk639hWkpXM6a4u6RT2/GXoAgSARMXMOlZjtq0wuZcXd5oiVzbgH2h7wP IBqLyCzJ0IApEK5QKi5Ir45KbNvpOgapKfWB+Gaf9iBsprGfmAWtYKFMWQoJbd8O2gFQ DZGg== X-Forwarded-Encrypted: i=1; AKwUvBw/niFEFeL0i2a7ni1PlhS50irJcBF2Pf+9EKcclN/SI6+Tmtp1WJLgKHK6cI6DJK2+SyuWWLXUL2s=@vger.kernel.org X-Gm-Message-State: AFuF++n0RQ48aCOYQlgSNOUxwO5LkVXCxwziaTuH/+oIph/r69InlrzC tQ9c7RAAweeWrd6jlNPXxXDvDX69nOX2CxBHOKnenJJusgqbP+qeb3wu X-Gm-Gg: AYBFou1CvuJ5D2snuTr5a9jSpqMT+NXxjdUhSL/VvlPjNmq29iqJMgpeYRFz4bfCUWl YI1jKbgpXYjjSIuQ0QU1yBs7TeIl9KrjF5sSr+gnpB4QdN0aMEPPVAEqXB6yqDwG1wle8qgfTeC znwh055e6KV4duIFZ/GqCcoQB3tima5APTrNPBERY8Hf/IVeaULiC8D6zGHd5YykI4YJQw0nvMC uYRbvo3m8Fo28XlM5Gh95HdR28rjEba7RkUY9H4dbSKmFDoqoX6KUCdZKc2jx5uax7YN6Z7uu/M xnGZ6peyBThu2gfnuIh2PlZ/Q9XfTvnS8SFveiAum+w/zfmBW1ZHAn5dV+Pw8iQlXAyqlbp6FO5 8KmyZSoTWsfwYbHASnyR3FQKIpTL3Kwcd3yEnWIHmtfbmIg/KIgDIyH6qzSihDKMvRuXnq0b7h+ dMrm7mXzgyvBCcgRPug1Yq92gaBU0Ci2Gn+CUjTBHNNelkmytGP/hFfhX07hbm9yXo1UYTuiizh k/f3SeD3Bg1UWF79OUDZlOvQA== X-Received: by 2002:a05:6000:4a1e:b0:482:9dc6:16c4 with SMTP id ffacd0b85a97d-485870870b6mr4790999f8f.1.1788476368800; Thu, 03 Sep 2026 15:59:28 -0700 (PDT) Received: from threads.localdomain ([84.68.179.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485885c5bbdsm1686142f8f.36.2026.09.03.15.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 15:59:28 -0700 (PDT) From: Lucas Tanure To: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Kevin Hilman , Martin Blumenstingl , Stephen Boyd Cc: Brian Masney , Chuan Liu , Jian Hu , Ronald Claveau , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Claude Fable 5 Subject: [PATCH 4/4] clk: meson: t7: don't mark sys_ampipe_nand as critical Date: Thu, 3 Sep 2026 23:59:21 +0100 Message-ID: <20260903225921.2290441-5-tanure@linux.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260903225921.2290441-1-tanure@linux.com> References: <20260903225921.2290441-1-tanure@linux.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sys_ampipe_nand clocks the pipeline stage inserted in the bus path between the SD/eMMC controllers and the NIC_MATRIX fabric. It does have identifiable consumers - the three MMC controllers - so marking it critical was the wrong tool: the clock should be referenced from the consumer nodes and claimed by the mmc driver instead. Drop the CLK_IS_CRITICAL flag and update the comment accordingly. sys_am2axi0..2 remain critical as they clock the AXI DMA bus itself and have no single identifiable consumer. This depends on the MMC controllers actually referencing the clock: the dt-bindings, mmc driver and t7 DTS changes adding the "pipeline" clock must land before this one, otherwise the boot hangs and memory corruption this clock caused are reintroduced. Fixes: 43e1705ecab9 ("clk: meson: t7: keep the memory fabric clocks running") Assisted-by: Claude Fable 5 Signed-off-by: Lucas Tanure --- drivers/clk/meson/t7-peripherals.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/meson/t7-peripherals.c b/drivers/clk/meson/t7-peripherals.c index 55d09e78593b..2f429ea86796 100644 --- a/drivers/clk/meson/t7-peripherals.c +++ b/drivers/clk/meson/t7-peripherals.c @@ -945,13 +945,13 @@ static T7_SYS_PCLK(sys_aucpu, SYS_CLK_EN0_REG0, 14, 0); static T7_SYS_PCLK(sys_cec, SYS_CLK_EN0_REG0, 16, 0); static T7_SYS_PCLK(sys_gdc, SYS_CLK_EN0_REG0, 17, 0); static T7_SYS_PCLK(sys_deswarp, SYS_CLK_EN0_REG0, 18, 0); +static T7_SYS_PCLK(sys_ampipe_nand, SYS_CLK_EN0_REG0, 19, 0); +static T7_SYS_PCLK(sys_ampipe_eth, SYS_CLK_EN0_REG0, 20, 0); /* - * NOTE: sys_ampipe_nand and sys_am2axi0..2 provide the clock to the AXI bus - * used for DMA between the peripherals and the DRAM. After the clocks are - * disabled, a device that starts a transfer cannot complete it. + * NOTE: sys_am2axi0..2 provide the clock to the AXI bus used for DMA between + * the peripherals and the DRAM. After the clocks are disabled, a device that + * starts a transfer cannot complete it. */ -static T7_SYS_PCLK(sys_ampipe_nand, SYS_CLK_EN0_REG0, 19, CLK_IS_CRITICAL); -static T7_SYS_PCLK(sys_ampipe_eth, SYS_CLK_EN0_REG0, 20, 0); static T7_SYS_PCLK(sys_am2axi0, SYS_CLK_EN0_REG0, 21, CLK_IS_CRITICAL); static T7_SYS_PCLK(sys_am2axi1, SYS_CLK_EN0_REG0, 22, CLK_IS_CRITICAL); static T7_SYS_PCLK(sys_am2axi2, SYS_CLK_EN0_REG0, 23, CLK_IS_CRITICAL); -- 2.55.0