Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Muzaffer Kadir <muzafferkadir@mainlining.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	 Abel Vesa <abelvesa@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	 Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Srinivas Kandagatla <srini@kernel.org>,
	 Ulf Hansson <ulfh@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	 "Joerg Roedel (AMD)" <joro@8bytes.org>,
	Will Deacon <will@kernel.org>,
	 Robin Murphy <robin.murphy@arm.com>, Lee Jones <lee@kernel.org>,
	 Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	 Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	 Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	 Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>,
	 Simona Vetter <simona@ffwll.ch>,
	Robert Marko <robimarko@gmail.com>,
	 Guru Das Srinagesh <linux@gurudas.dev>,
	Amit Kucheria <amitk@kernel.org>,
	 Thara Gopinath <thara.gopinath@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	 Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	 Lukasz Luba <lukasz.luba@arm.com>, Kees Cook <kees@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	 "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	 David Heidelberg <david@ixit.cz>,
	Dang Huynh <danct12@riseup.net>,
	phone-devel@vger.kernel.org,  linux-arm-msm@vger.kernel.org,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	iommu@lists.linux.dev,  mfd@lists.linux.dev,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	 linux-pm@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v2 01/19] dt-bindings: clock: qcom: Add MSM8952 global clock controller
Date: Fri, 18 Sep 2026 12:02:02 +0200	[thread overview]
Message-ID: <20260918-liberal-significant-crow-f1e66f@quoll> (raw)
In-Reply-To: <20260916-msm8952-initial-support-v2-1-798c2602dde1@mainlining.org>

On Wed, Sep 16, 2026 at 05:22:06PM +0300, Muzaffer Kadir wrote:
> Add a device tree binding to describe clocks, resets and power domains
> provided by the global clock controller on MSM8952 SoC.
> 
> Signed-off-by: Muzaffer Kadir <muzafferkadir@mainlining.org>

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

> ---
>  .../bindings/clock/qcom,gcc-msm8952.yaml           |  56 ++++++
>  include/dt-bindings/clock/qcom,gcc-msm8952.h       | 217 +++++++++++++++++++++
>  2 files changed, 273 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8952.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8952.yaml
> new file mode 100644
> index 000000000000..274dde633e17
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8952.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8952.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Global Clock & Reset Controller on MSM8952
> +
> +maintainers:
> +  - Muzaffer Kadir <muzafferkadir@mainlining.org>
> +
> +description: |
> +  Qualcomm global clock control module provides the clocks, resets and power
> +  domains on MSM8952.
> +
> +  See also::

git grep "also::" -- Documentation/devicetree/bindings/clock/

I asked you month ago here:
<e3fb3794-ca7a-4794-8036-b69e563aaa57@kernel.org>
to not work on old forks.

Old fork which you should not use is postmarketos, lineageos, whatever
Android fork kernel, and whatever other tree which is not upstream from
kernel.org.

Best regards,
Krzysztof


  reply	other threads:[~2026-09-18 10:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 14:22 [PATCH v2 00/19] Add Initial Support For MSM8952, Add General Mobile Shamrock Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 01/19] dt-bindings: clock: qcom: Add MSM8952 global clock controller Muzaffer Kadir via B4 Relay
2026-09-18 10:02   ` Krzysztof Kozlowski [this message]
2026-09-18 13:01     ` Muzaffer Kadir
2026-09-18 13:26       ` Krzysztof Kozlowski
2026-09-18 13:38         ` Muzaffer Kadir
2026-09-16 14:22 ` [PATCH v2 02/19] clk: qcom: Add global clock controller driver for MSM8952 Muzaffer Kadir via B4 Relay
2026-09-17  4:19   ` Taniya Das
2026-09-17 12:25     ` Muzaffer Kadir
2026-09-21  8:46       ` Konrad Dybcio
2026-09-16 14:22 ` [PATCH v2 03/19] dt-bindings: nvmem: Add compatible " Muzaffer Kadir via B4 Relay
2026-09-18 10:09   ` Krzysztof Kozlowski
2026-09-16 14:22 ` [PATCH v2 04/19] dt-bindings: power: rpmpd: Add MSM8952 power domains Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 05/19] dt-bindings: mmc: sdhci-msm: Add MSM8952 compatible Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 06/19] dt-bindings: vendor-prefixes: Add General Mobile Muzaffer Kadir via B4 Relay
2026-09-18 10:02   ` Krzysztof Kozlowski
2026-09-16 14:22 ` [PATCH v2 07/19] dt-bindings: arm: qcom: Document MSM8952 SoC binding Muzaffer Kadir via B4 Relay
2026-09-18 10:03   ` Krzysztof Kozlowski
2026-09-16 14:22 ` [PATCH v2 08/19] dt-bindings: iommu: qcom,iommu: Add MSM8952 IOMMU to SMMUv2 compatibles Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 09/19] dt-bindings: mfd: qcom,tcsr: Add compatible for MSM8952 Muzaffer Kadir via B4 Relay
2026-09-24 14:28   ` (subset) " Lee Jones
2026-09-16 14:22 ` [PATCH v2 10/19] dt-bindings: display/msm: qcom, mdp5: Add MSM8952 compatible Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 11/19] dt-bindings: firmware: qcom,scm: Document MSM8952 SCM Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 12/19] dt-bindings: clock: qcom,rpmcc: Add MSM8952 compatible Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 13/19] drm: msm: mdp5: Add MDP5 configuration for MSM8952 Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 14/19] soc: qcom: ubwc: Add UBWC config " Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 15/19] dt-bindings: thermal: tsens: Add MSM8952 Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 16/19] thermal: qcom: tsens: Add support for MSM8952 tsens Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 17/19] arm64: dts: qcom: Add initial support for MSM8952 Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 18/19] dt-bindings: input: touchscreen: goodix: Add binding for GT970 Muzaffer Kadir via B4 Relay
2026-09-16 14:22 ` [PATCH v2 19/19] arm64: dts: qcom: generalmobile-shamrock: new device Muzaffer Kadir via B4 Relay
2026-09-18 10:06   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918-liberal-significant-crow-f1e66f@quoll \
    --to=krzk@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=amitk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bmasney+clk@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=danct12@riseup.net \
    --cc=daniel.lezcano@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=gpiccoli@igalia.com \
    --cc=iommu@lists.linux.dev \
    --cc=jbrunet+clk@baylibre.com \
    --cc=jesszhan0024@gmail.com \
    --cc=joro@8bytes.org \
    --cc=kees@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@gurudas.dev \
    --cc=lukasz.luba@arm.com \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mfd@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=muzafferkadir@mainlining.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=robimarko@gmail.com \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=robin.murphy@arm.com \
    --cc=rui.zhang@intel.com \
    --cc=sboyd@kernel.org \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=srini@kernel.org \
    --cc=thara.gopinath@gmail.com \
    --cc=tony.luck@intel.com \
    --cc=tzimmermann@suse.de \
    --cc=ulfh@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox