* [PATCH] mmc: dw_mmc-rockchip: correct property names in debug
@ 2018-03-01 10:36 John Keeping
2018-03-01 10:57 ` Heiko Stübner
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: John Keeping @ 2018-03-01 10:36 UTC (permalink / raw)
To: linux-mmc
Cc: Ulf Hansson, Heiko Stuebner, Jaehoon Chung, linux-rockchip,
John Keeping, linux-arm-kernel
Following up the device tree fixed in commits e78c637127ee ("ARM: dts:
rockchip: Fix DWMMC clocks") and ca9eee95a2de ("arm64: dts: rockchip:
Fix DWMMC clocks", 2018-02-15), avoid confusion by using the correct
property name in the debug output if clocks are not found.
Signed-off-by: John Keeping <john@metanate.com>
---
drivers/mmc/host/dw_mmc-rockchip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
index 339295212935..40d7de2eea12 100644
--- a/drivers/mmc/host/dw_mmc-rockchip.c
+++ b/drivers/mmc/host/dw_mmc-rockchip.c
@@ -282,11 +282,11 @@ static int dw_mci_rk3288_parse_dt(struct dw_mci *host)
priv->drv_clk = devm_clk_get(host->dev, "ciu-drive");
if (IS_ERR(priv->drv_clk))
- dev_dbg(host->dev, "ciu_drv not available\n");
+ dev_dbg(host->dev, "ciu-drive not available\n");
priv->sample_clk = devm_clk_get(host->dev, "ciu-sample");
if (IS_ERR(priv->sample_clk))
- dev_dbg(host->dev, "ciu_sample not available\n");
+ dev_dbg(host->dev, "ciu-sample not available\n");
host->priv = priv;
--
2.16.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: dw_mmc-rockchip: correct property names in debug
2018-03-01 10:36 [PATCH] mmc: dw_mmc-rockchip: correct property names in debug John Keeping
@ 2018-03-01 10:57 ` Heiko Stübner
2018-03-01 11:21 ` Robin Murphy
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2018-03-01 10:57 UTC (permalink / raw)
To: John Keeping
Cc: Jaehoon Chung, linux-rockchip, Ulf Hansson, linux-mmc,
linux-arm-kernel
Am Donnerstag, 1. März 2018, 11:36:25 CET schrieb John Keeping:
> Following up the device tree fixed in commits e78c637127ee ("ARM: dts:
> rockchip: Fix DWMMC clocks") and ca9eee95a2de ("arm64: dts: rockchip:
> Fix DWMMC clocks", 2018-02-15), avoid confusion by using the correct
> property name in the debug output if clocks are not found.
>
> Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: dw_mmc-rockchip: correct property names in debug
2018-03-01 10:36 [PATCH] mmc: dw_mmc-rockchip: correct property names in debug John Keeping
2018-03-01 10:57 ` Heiko Stübner
@ 2018-03-01 11:21 ` Robin Murphy
2018-03-05 7:35 ` Shawn Lin
[not found] ` <20180301103625.7285-1-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
3 siblings, 0 replies; 5+ messages in thread
From: Robin Murphy @ 2018-03-01 11:21 UTC (permalink / raw)
To: John Keeping, linux-mmc
Cc: Jaehoon Chung, linux-rockchip, Ulf Hansson, Heiko Stuebner,
linux-arm-kernel
On 01/03/18 10:36, John Keeping wrote:
> Following up the device tree fixed in commits e78c637127ee ("ARM: dts:
> rockchip: Fix DWMMC clocks") and ca9eee95a2de ("arm64: dts: rockchip:
> Fix DWMMC clocks", 2018-02-15), avoid confusion by using the correct
> property name in the debug output if clocks are not found.
Yeah, I was lazy since this inconsistency was already present and I just
wanted to make my thing work :)
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> drivers/mmc/host/dw_mmc-rockchip.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index 339295212935..40d7de2eea12 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -282,11 +282,11 @@ static int dw_mci_rk3288_parse_dt(struct dw_mci *host)
>
> priv->drv_clk = devm_clk_get(host->dev, "ciu-drive");
> if (IS_ERR(priv->drv_clk))
> - dev_dbg(host->dev, "ciu_drv not available\n");
> + dev_dbg(host->dev, "ciu-drive not available\n");
>
> priv->sample_clk = devm_clk_get(host->dev, "ciu-sample");
> if (IS_ERR(priv->sample_clk))
> - dev_dbg(host->dev, "ciu_sample not available\n");
> + dev_dbg(host->dev, "ciu-sample not available\n");
>
> host->priv = priv;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mmc: dw_mmc-rockchip: correct property names in debug
2018-03-01 10:36 [PATCH] mmc: dw_mmc-rockchip: correct property names in debug John Keeping
2018-03-01 10:57 ` Heiko Stübner
2018-03-01 11:21 ` Robin Murphy
@ 2018-03-05 7:35 ` Shawn Lin
[not found] ` <20180301103625.7285-1-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
3 siblings, 0 replies; 5+ messages in thread
From: Shawn Lin @ 2018-03-05 7:35 UTC (permalink / raw)
To: John Keeping
Cc: Ulf Hansson, Heiko Stuebner, shawn.lin, linux-mmc, Jaehoon Chung,
linux-rockchip, linux-arm-kernel
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <20180301103625.7285-1-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH] mmc: dw_mmc-rockchip: correct property names in debug
[not found] ` <20180301103625.7285-1-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
@ 2018-03-15 10:23 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2018-03-15 10:23 UTC (permalink / raw)
To: John Keeping
Cc: Jaehoon Chung, open list:ARM/Rockchip SoC...,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner,
Linux ARM
On 1 March 2018 at 11:36, John Keeping <john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org> wrote:
> Following up the device tree fixed in commits e78c637127ee ("ARM: dts:
> rockchip: Fix DWMMC clocks") and ca9eee95a2de ("arm64: dts: rockchip:
> Fix DWMMC clocks", 2018-02-15), avoid confusion by using the correct
> property name in the debug output if clocks are not found.
>
> Signed-off-by: John Keeping <john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/dw_mmc-rockchip.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index 339295212935..40d7de2eea12 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -282,11 +282,11 @@ static int dw_mci_rk3288_parse_dt(struct dw_mci *host)
>
> priv->drv_clk = devm_clk_get(host->dev, "ciu-drive");
> if (IS_ERR(priv->drv_clk))
> - dev_dbg(host->dev, "ciu_drv not available\n");
> + dev_dbg(host->dev, "ciu-drive not available\n");
>
> priv->sample_clk = devm_clk_get(host->dev, "ciu-sample");
> if (IS_ERR(priv->sample_clk))
> - dev_dbg(host->dev, "ciu_sample not available\n");
> + dev_dbg(host->dev, "ciu-sample not available\n");
>
> host->priv = priv;
>
> --
> 2.16.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-15 10:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-01 10:36 [PATCH] mmc: dw_mmc-rockchip: correct property names in debug John Keeping
2018-03-01 10:57 ` Heiko Stübner
2018-03-01 11:21 ` Robin Murphy
2018-03-05 7:35 ` Shawn Lin
[not found] ` <20180301103625.7285-1-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
2018-03-15 10:23 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox