public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Linux MMC List <linux-mmc@vger.kernel.org>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Ian Molton <ian.molton@codethink.co.uk>
Subject: Re: [PATCH 10/11] ARM: shmobile: r8a7790: Reference DMA channels in SDHI DT nodes
Date: Mon, 04 Aug 2014 16:03:47 +0200	[thread overview]
Message-ID: <2157107.DzSugegZxt@avalon> (raw)
In-Reply-To: <CAMuHMdWZxNWDBc+NyrmJ1DaME+JycuZwB+wpEDgaDdkw6Bv3Qw@mail.gmail.com>

Hi Geert,

On Monday 04 August 2014 11:01:28 Geert Uytterhoeven wrote:
> On Wed, Jul 16, 2014 at 12:45 AM, Laurent Pinchart wrote:
> > Add references to the transmit and receive DMA channels in the four
> > SDHI nodes.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> 
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> but see below for a question (this also applies to other members of the
> R-Car Gen 2 family)...
> 
> > ---
> > 
> >  arch/arm/boot/dts/r8a7790.dtsi | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi
> > b/arch/arm/boot/dts/r8a7790.dtsi index 465008a..2ea3b2a 100644
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > @@ -406,6 +410,8 @@
> >                 reg = <0 0xee140000 0 0x100>;
> >                 interrupts = <0 167 IRQ_TYPE_LEVEL_HIGH>;
> >                 clocks = <&mstp3_clks R8A7790_CLK_SDHI2>;
> > +               dmas = <&dmac0 0xc1>, <&dmac0 0xc2>;
> > +               dma-names = "tx", "rx";
> >                 cap-sd-highspeed;
> >                 status = "disabled";
> >         };
> > @@ -415,6 +421,8 @@
> >                 reg = <0 0xee160000 0 0x100>;
> >                 interrupts = <0 168 IRQ_TYPE_LEVEL_HIGH>;
> >                 clocks = <&mstp3_clks R8A7790_CLK_SDHI3>;
> > +               dmas = <&dmac0 0xd3>, <&dmac0 0xd4>;
> > +               dma-names = "tx", "rx";
> >                 cap-sd-highspeed;
> >                 status = "disabled";
> >         };
> 
> SDHI2 and SDHI3 actually have 2 sets of 2 (TX and RX) DMA channels:
> the normal one, and the "C2" one. However, I didn't get any wiser about this
> "C2" by browsing through the docs.

I didn't either, so I've decided to ignore them for now. It's funny sometimes 
how life gets simpler when you selectively ignore information ;-)

More seriously, if anyone has any information regarding what the "C2" channels 
are, that would be appreciated.

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2014-08-04 14:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 22:45 [PATCH 00/11] MMCIF and SDHI DMA support in DT for R-Car H2 and M2 Laurent Pinchart
2014-07-15 22:45 ` [PATCH 01/11] mmc: sh_mmcif: Document DT bindings Laurent Pinchart
2014-07-26  9:39   ` Ulf Hansson
2014-07-15 22:45 ` [PATCH 02/11] mmc: sh_mmcif: Fix DMA slave address configuration Laurent Pinchart
2014-07-26  9:40   ` Ulf Hansson
2014-07-15 22:45 ` [PATCH 03/11] mmc: sh_mmcif: Configure DMA slave bus width Laurent Pinchart
2014-07-26  9:40   ` Ulf Hansson
2014-07-15 22:45 ` [PATCH 04/11] mmc: tmio: " Laurent Pinchart
2014-07-26  9:41   ` Ulf Hansson
2014-07-15 22:45 ` [PATCH 05/11] mmc: tmio: Fix DMA source address Laurent Pinchart
2014-07-16  1:39   ` Kuninori Morimoto
2014-07-16  9:41     ` Laurent Pinchart
2014-07-17  1:00       ` Kuninori Morimoto
2014-07-15 22:45 ` [PATCH 06/11] ARM: shmobile: r8a7790: Rename mmcif node to mmc Laurent Pinchart
2014-07-15 22:45 ` [PATCH 07/11] ARM: shmobile: r8a7791: Add MMCIF0 DT node Laurent Pinchart
2014-07-15 22:45 ` [PATCH 08/11] ARM: shmobile: r8a7790: Reference DMA channels in MMCIF DT nodes Laurent Pinchart
2014-07-15 22:45 ` [PATCH 09/11] ARM: shmobile: r8a7791: Reference DMA channels in MMCIF DT node Laurent Pinchart
2014-08-04  8:49   ` Geert Uytterhoeven
2014-07-15 22:45 ` [PATCH 10/11] ARM: shmobile: r8a7790: Reference DMA channels in SDHI DT nodes Laurent Pinchart
2014-08-04  9:01   ` Geert Uytterhoeven
2014-08-04 14:03     ` Laurent Pinchart [this message]
2014-07-15 22:45 ` [PATCH 11/11] ARM: shmobile: r8a7791: " Laurent Pinchart
2014-08-04  9:01   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2157107.DzSugegZxt@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=geert@linux-m68k.org \
    --cc=ian.molton@codethink.co.uk \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox