From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Ram Prakash Gupta <quic_rampraka@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sachin Gupta <quic_sachgupt@quicinc.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
quic_cang@quicinc.com, quic_nguyenb@quicinc.com,
quic_bhaskarv@quicinc.com, quic_mapa@quicinc.com,
quic_narepall@quicinc.com, quic_nitirawa@quicinc.com,
quic_sartgarg@quicinc.com
Subject: Re: [PATCH V3 3/4] mmc: sdhci-msm: Add Device tree parsing logic for DLL settings
Date: Wed, 23 Jul 2025 12:37:02 +0200 [thread overview]
Message-ID: <2182b484-9ccc-4ebf-89f4-519646958413@oss.qualcomm.com> (raw)
In-Reply-To: <d0af754d-8deb-041f-8e34-1c1214fccb09@quicinc.com>
On 7/23/25 12:14 PM, Ram Prakash Gupta wrote:
>
> On 6/10/2025 5:47 PM, Ram Prakash Gupta wrote:
>> Hi Dmitry,
>>
>> As updated in [PATCH V3 2/2] of this series, I have started now to continue
>> this work. Will address your comment next.
>>
>> Thanks,
>> Ram
[...]
>>> And the pointer to dll_table is lost, lingering for the driver lifetime.
>>> Please drop the devm_ part and kfree() it once it is not used anymore.
>
> ok, I ll allocate memory using kzalloc in function sdhci_msm_dt_get_array
> and kfree() after copying data in this function.
You can use __free() nowadays (see e.g. drivers/soc/qcom/mdt_loader.c :
mdt_load_split_segment), which will dispose of the memory when it goes
out of scope, limiting the need to clean it up every error path
separately
Konrad
next prev parent reply other threads:[~2025-07-23 10:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 9:47 [PATCH V3 0/4] mmc: sdhci-msm: Rectify DLL programming sequence for SDCC Sachin Gupta
2025-01-22 9:47 ` [PATCH V3 1/4] dt-bindings: mmc: Add dll-hsr-list for HS400 and HS200 modes Sachin Gupta
2025-01-22 10:26 ` Krzysztof Kozlowski
[not found] ` <e0f43fc7-2f38-335d-1515-c97594a55566@quicinc.com>
2025-06-10 12:53 ` Krzysztof Kozlowski
2025-06-10 13:07 ` Ram Prakash Gupta
2025-06-10 13:12 ` Krzysztof Kozlowski
2025-06-26 14:16 ` Ram Prakash Gupta
2025-06-26 14:24 ` Ram Prakash Gupta
2025-06-26 17:42 ` Krzysztof Kozlowski
2025-06-27 6:48 ` Ram Prakash Gupta
2025-06-27 13:57 ` Konrad Dybcio
2025-06-27 14:50 ` Krzysztof Kozlowski
2025-06-30 6:33 ` Ram Prakash Gupta
2025-01-22 11:26 ` Rob Herring (Arm)
2025-01-22 9:47 ` [PATCH V3 2/4] mmc: sdhci-msm: Add core_major, minor to msm_host structure Sachin Gupta
2025-01-22 9:55 ` Dmitry Baryshkov
2025-01-22 9:47 ` [PATCH V3 3/4] mmc: sdhci-msm: Add Device tree parsing logic for DLL settings Sachin Gupta
2025-01-22 9:57 ` Dmitry Baryshkov
2025-06-10 12:17 ` Ram Prakash Gupta
2025-07-23 10:14 ` Ram Prakash Gupta
2025-07-23 10:37 ` Konrad Dybcio [this message]
2025-07-23 12:02 ` Ram Prakash Gupta
2025-01-22 9:47 ` [PATCH V3 4/4] mmc: sdhci-msm: Rectify DLL programming sequence for SDCC Sachin Gupta
2025-01-22 10:00 ` Dmitry Baryshkov
2025-06-10 12:22 ` Ram Prakash Gupta
2025-06-10 13:38 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2182b484-9ccc-4ebf-89f4-519646958413@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=adrian.hunter@intel.com \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_mapa@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sachgupt@quicinc.com \
--cc=quic_sartgarg@quicinc.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox