linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Chris Ball <cjb@laptop.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH 08/12] mmc: sh_mobile_sdhi: Convert to clk_prepare/unprepare
Date: Wed, 11 Dec 2013 13:01:21 +0100	[thread overview]
Message-ID: <23114596.UeGyAebmZh@avalon> (raw)
In-Reply-To: <2163819.oJv92Ekf2I@avalon>

Hi Chris,

On Tuesday 26 November 2013 03:02:48 Laurent Pinchart wrote:
> On Saturday 09 November 2013 13:56:40 Laurent Pinchart wrote:
> > Hi Chris,
> > 
> > Could you please pick this patch up ?
> 
> Ping ?

PING ?

> As this patch is a dependency for other series that will go through
> different trees, could you please provide a stable branch in your tree with
> this patch included that you will push to v3.14 ?
> 
> > On Tuesday 29 October 2013 09:09:37 Guennadi Liakhovetski wrote:
> > > On Mon, 28 Oct 2013, Laurent Pinchart wrote:
> > > > Turn clk_enable() and clk_disable() calls into clk_prepare_enable()
> > > > and clk_disable_unprepare() to get ready for the migration to the
> > > > common clock framework.
> > > > 
> > > > Cc: Chris Ball <cjb@laptop.org>
> > > > Cc: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > > > Cc: linux-mmc@vger.kernel.org
> > > > Signed-off-by: Laurent Pinchart
> > > > <laurent.pinchart+renesas@ideasonboard.com>
> > > 
> > > Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > > 
> > > Thanks
> > > Guennadi
> > > 
> > > > ---
> > > > 
> > > >  drivers/mmc/host/sh_mobile_sdhi.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c
> > > > b/drivers/mmc/host/sh_mobile_sdhi.c index f344659..ed1718a 100644
> > > > --- a/drivers/mmc/host/sh_mobile_sdhi.c
> > > > +++ b/drivers/mmc/host/sh_mobile_sdhi.c
> > > > @@ -54,7 +54,7 @@ static int sh_mobile_sdhi_clk_enable(struct
> > > > platform_device *pdev, unsigned int
> > > >  	struct mmc_host *mmc = platform_get_drvdata(pdev);
> > > >  	struct tmio_mmc_host *host = mmc_priv(mmc);
> > > >  	struct sh_mobile_sdhi *priv = container_of(host->pdata, struct
> > > >  	sh_mobile_sdhi, mmc_data);
> > > > 
> > > > -	int ret = clk_enable(priv->clk);
> > > > +	int ret = clk_prepare_enable(priv->clk);
> > > >  	if (ret < 0)
> > > >  		return ret;
> > > > 
> > > > @@ -67,7 +67,7 @@ static void sh_mobile_sdhi_clk_disable(struct
> > > > platform_device *pdev)
> > > >  	struct mmc_host *mmc = platform_get_drvdata(pdev);
> > > >  	struct tmio_mmc_host *host = mmc_priv(mmc);
> > > >  	struct sh_mobile_sdhi *priv = container_of(host->pdata, struct
> > > >  	sh_mobile_sdhi, mmc_data);
> > > > 
> > > > -	clk_disable(priv->clk);
> > > > +	clk_disable_unprepare(priv->clk);
> > > >  }
> > > >  
> > > >  static int sh_mobile_sdhi_wait_idle(struct tmio_mmc_host *host)

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2013-12-11 12:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-28 22:49 [PATCH 00/12] Prepare various SH/R Mobile/Car drivers for CCF migration Laurent Pinchart
2013-10-28 22:49 ` [PATCH 07/12] mmc: sh_mmcif: Convert to clk_prepare/unprepare Laurent Pinchart
2013-10-29  8:10   ` Guennadi Liakhovetski
2013-10-30 22:23     ` Guennadi Liakhovetski
2013-10-30 23:13       ` Laurent Pinchart
2013-10-30 23:27         ` Ulf Hansson
2013-10-30 23:48           ` Laurent Pinchart
2013-10-28 22:49 ` [PATCH 08/12] mmc: sh_mobile_sdhi: " Laurent Pinchart
2013-10-29  8:09   ` Guennadi Liakhovetski
2013-11-09 12:56     ` Laurent Pinchart
2013-11-26  2:02       ` Laurent Pinchart
2013-12-11 12:01         ` Laurent Pinchart [this message]
2013-12-12  1:29           ` Chris Ball
2013-12-12  2:16             ` Laurent Pinchart
2013-12-12  2:25               ` Chris Ball
2013-12-14  1:05                 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23114596.UeGyAebmZh@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=cjb@laptop.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).